Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max len for changed_files (max cell len error in googleapi) #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Max len for changed_files (max cell len error in googleapi) #68

wants to merge 1 commit into from

Conversation

HadronCollider
Copy link
Collaborator

close #67

thehighestmath
thehighestmath requested changes Dec 15, 2024
View reviewed changes
commits_parser.py
Comment on lines +45 to +46
if len(changed_files) > GOOGLE_MAX_CELL_LEN:
changed_files = changed_files[:GOOGLE_MAX_CELL_LEN]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я бы эти две строки сжал до одной

changed_files = changed_files[:GOOGLE_MAX_CELL_LEN]

и вот почему

>>> 'qwe'[:2]
'qw'
>>> 'qwe'[:10000]
'qwe'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehighestmath thehighestmath thehighestmath requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@HadronCollider @thehighestmath