-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification system #3216
base: main
Are you sure you want to change the base?
Notification system #3216
Conversation
I have added the command to the |
Yes notifications for all of those will be good. Thanks! |
Head branch was pushed to by a user without write access
Fixed all the issues, please verify! |
Also added the checkin_reminder_notification command in the run_daily schedule |
@DonnieBLT Can this please be merged since it frequently gets merge conflicts due to the model addition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would only want to show checkin reminders to users who belong to an organization that has check ins turned on.
def handle(self, *args, **options): | ||
cutoff_date = now().date() - timedelta(days=1) | ||
|
||
users_without_checkin = User.objects.exclude(dailystatusreport__date__gte=cutoff_date) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would only want to show checkin reminders to users who belong to an organization that has check ins turned on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The organization model does not appear to have any attribute that indicates whether it has enabled check-ins. Could you please guide me on how to identify such organizations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be to join the DailyStatusReport to the organization so that daily status reports would only be sent to organizations that had reminders enabled. This would involve a migration.
I merged the conflict, hopefully that was right. |
Thanks a lot for that! I'll make sure to finish this up as soon as possible |
fixes #2560
A notification system is created for the users that looks like this:
screen-capture (1).webm
However, in order to fully close this issue we need to create a cron job via some scheduler to send these reminders to users.
If you can also review #3209 then it can be easily incorporated