-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added all previous GSOC organizations to organizations #3285
base: main
Are you sure you want to change the base?
Conversation
@DonnieBLT sir, while adding the organizations, I encountered the following problem: |
Approach to Follow:
Points to Consider:
@DonnieBLT , could you please provide your feedback on this suggestion? Also, let me know if there's anything you'd like to add or remove. @tsu-ki , if you have any questions, feel free to ask—I'm here ! |
Sounds good! |
@JisanAR03 thank you so much for your extensive explanation, it cleared a lot of things for me. @DonnieBLT sir, please review this and guide me on this, thank you! |
@tsu-ki , please consider :
2 . Using slugs as a workaround for missing domain links might lead to inconsistencies in future updates. and keeps the organization-user mapping clean without introducing unnecessary fields.
|
I've shared the script with you on slack, please look into it. |
@JisanAR03 @DonnieBLT I've created a seperate class that handles
Screen.Recording.2025-01-28.at.7.21.44.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add a new field in the organisation table for gsoc_years for a comma separated list - and update all the css to tailwind? Also we don't need the unverified domainview anymore as we will have a new organization page soon.
sure, I'll make the required changes and update PR. I'm shifting to a new place, so it might take me a couple of days to complete this. I hope that won't be a problem, thank you for your understanding |
Sounds good! Good luck with the move! |
/kudos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good addition
@@ -770,6 +771,7 @@ | |||
path("sponsor/", sponsor_view, name="sponsor"), | |||
path("donate/", donate_view, name="donate"), | |||
path("organizations/", DomainListView.as_view(), name="domain_lists"), | |||
path("domain/<str:org_name>/unverified", UnverifiedDomainView.as_view(), name="domain_unverified"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this. We can have domains that are unverified in the regular domain view - and I believe these can just go into the Organization table. Please make sure to have a field for the GitHub organization field.
Closes: #3264
Work-in progress PR
(I haven't added consistent UI yet so the cards aren't displayed properly, please don't mind that)
Screen.Recording.2025-01-28.at.12.56.43.AM.mov