Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommendation and recommendation blurb functionality #3742

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tsu-ki
Copy link
Contributor

@tsu-ki tsu-ki commented Feb 28, 2025

Closes: #2632

Screen.Recording.2025-02-28.at.8.09.28.PM.mov

@@ -446,7 +498,61 @@
user_issues.update(is_hidden=hide)
request.user.userprofile.issues_hidden = hide
request.user.userprofile.save()
return redirect(reverse("profile", kwargs={"slug": kwargs.get("slug")}))
return redirect(self.request.path_info)

Check warning

Code scanning / CodeQL

URL redirection from remote source Medium

Untrusted URL redirection depends on a
user-provided value
.
messages.success(request, "Recommendation removed successfully!")
except User.DoesNotExist:
messages.error(request, "User not found.")
return redirect(request.META.get("HTTP_REFERER", "/"))

Check warning

Code scanning / CodeQL

URL redirection from remote source Medium

Untrusted URL redirection depends on a
user-provided value
.
@tsu-ki
Copy link
Contributor Author

tsu-ki commented Feb 28, 2025

@DonnieBLT sir, should I add hover functionality over the recommendations dropdown list button? So, whenever user hovers their cursor over the button, the dropdown list is displayed?

@DonnieBLT
Copy link
Collaborator

all should be expanded there should be no hover lists

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure everything is expanded on the use profile so there is no hover lists

@DonnieBLT
Copy link
Collaborator

please also fix any CodeQL errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add recommendations to allow for users to recommend others on their profile
2 participants