Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkmarx results parser - Normalize paths #71

Merged
merged 2 commits into from
May 3, 2024

Conversation

cx-rafaelc
Copy link
Contributor

Normalize SAST results file path in order to compute OWASP scorecard on Windows or Linux base scans .

@davewichers
Copy link
Contributor

davewichers commented May 3, 2024

@darkspirit510 - can you look at this change? Are there other parsers we should make a similar change to in order to platform independent, like this change does? This change looks fine to me.

Copy link
Contributor

@nunoocx nunoocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davewichers davewichers merged commit 7cfea6d into OWASP-Benchmark:main May 3, 2024
1 check passed
@davewichers
Copy link
Contributor

@darkspirit510 - I merged this, but would still like you to look if a similar change should be applied to other parsers.

@darkspirit510
Copy link
Contributor

org.owasp.benchmarkutils.score.parsers.Reader#extractFilename should already handle Linux and Windows path to extract filename. You could check if this works and if not, fix the method so all readers beneftit from it 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants