Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added footer component #57 #67

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Added footer component #57 #67

merged 8 commits into from
Nov 19, 2024

Conversation

Yashgupta9330
Copy link
Contributor

This Pull Request solves Issue #57

Added files:

frontend/components/footer.tsx --> added footer component
.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the Footer component @Yashgupta9330!

Please look into addressing the comments below when you get a chance:

frontend/public/owasp.png Outdated Show resolved Hide resolved
frontend/src/components/Footer.tsx Outdated Show resolved Hide resolved
frontend/src/components/Footer.tsx Outdated Show resolved Hide resolved
frontend/src/components/Footer.tsx Outdated Show resolved Hide resolved
frontend/src/components/Footer.tsx Outdated Show resolved Hide resolved
@Yashgupta9330
Copy link
Contributor Author

Okk i will change it

@Yashgupta9330
Copy link
Contributor Author

should i add these links for project https://nest.owasp.dev/projects/ for https://nest.owasp.dev/projects/contribute/
for contribute

@Yashgupta9330
Copy link
Contributor Author

the problem is coming in linting

@tsu-ki
Copy link
Collaborator

tsu-ki commented Nov 18, 2024

@Yashgupta9330 did you run the pre-commit command before making the commit?

@arkid15r
Copy link
Collaborator

the problem is coming in linting

please run make pre-commit and commit the changes

I also recommend running pre-commit install

@Yashgupta9330
Copy link
Contributor Author

okk

@Yashgupta9330
Copy link
Contributor Author

Yashgupta9330 commented Nov 18, 2024

@arkid15r and @tsu-ki I have fixed the linting issue

@arkid15r arkid15r linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashgupta9330 thanks for the PR and all the reviewers for reviewing it!

@arkid15r arkid15r added this pull request to the merge queue Nov 19, 2024
Merged via the queue into OWASP:main with commit 0886525 Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement footer component
5 participants