Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: morphoblue integration #510

Merged
merged 16 commits into from
Nov 16, 2023

Conversation

robercano
Copy link
Contributor

@robercano robercano commented Nov 8, 2023

Ticket URL

https://app.shortcut.com/oazo-apps/epic/12346?cf_workflow=500000053&ct_workflow=all&group_by=none&vc_group_by=day

Description of Changes

  • Added morphoblue package with latest MorphoBlue contracts and some helper scripts
  • Added MorphoBlue actions and operations
  • Added basic tests for MorphoBlue protocol
  • Added integration tests for Borrow Operations
  • Added unfinished tests for Multiply Operations (skipped at the time)
  • Added flashloan functionality to MockExchange (unused at the moment, added for Multiply)
  • Added utils and helpers to test Morpho (include parameters casting and calculations)
  • Added Morpho tests template to be used for new tests
  • Changed test deploy system to accept extra deployment/post-deployment/configuration callbacks (used to deploy Morpho locally and to configure the system to work with Morpho in an isolated environment)
  • Added new yarn command yarn test:integration to dma-contracts. These will run when running yarn test from the top level
  • Added yarn test:unit:nocompile, yarn test:e2e:nocompile and yarn test:integration:nocompile to dma-contracts
  • Now yarn test in dma-contracts forces the compilation for unit tests but not for the rest of the tests so tests are run faster
  • Modified yarn:symlink to also symlink morpho contracts

How to Test

In general yarn test. If you want to only test the changes:

$ cd packages/dma-contracts
$ yarn test:integration

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • [✔️] All checks are passing
  • [✔️] PR is linked to a corresponding ticket
  • [✔️] PR title is clear and concise
  • [✔️] Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • [✔️] Documentation has been updated if necessary

@robercano robercano requested a review from fenris85 November 8, 2023 12:26
@robercano robercano self-assigned this Nov 8, 2023
Copy link

codesandbox bot commented Nov 8, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

This pull request has been linked to Shortcut Story #12364: [SC] New Actions SC for Morpho Blue.

@jakubswierczek jakubswierczek self-requested a review November 16, 2023 10:35
@robercano robercano merged commit 5d547d0 into dev Nov 16, 2023
@robercano robercano deleted the rc/sc-12364/sc-new-actions-sc-for-morpho-blue branch November 16, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants