Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge refactoring to ease project maintenance #340

Closed

Conversation

xanthio
Copy link
Contributor

@xanthio xanthio commented May 11, 2024

Here is a proposition that aims to ease project maintenability :

  • Matrixing of the workflows is created dynamically so they will run for a new familly as soon as it is added
  • Supported Devices and Family are now append in the .cmake file to ease the addition of a new family
  • ST Cube / CMSIS / HAL repos version are defined in the .cmake to avoid conflicts between 2 PR for 2 family versions updates.
  • ST repos dependency are checked each night and a PR is created if a new version exists
  • Every night a workflow runs to check for devices existing on ST website but not supported

@xanthio
Copy link
Contributor Author

xanthio commented May 11, 2024

Note: device STM32GBK1CB exists in supported devices list (g4.cmake) but I can't find where does it come from.

Copy link
Collaborator

@Hish15 Hish15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, those changes are really welcome, thanks a lot!
That being said one single commit for so many changes is risky.
Can you split the changes into at leats 2/3 PR, one or two for the CI changes, and one for the changes to the families handling.
If something is broken too many changes at once is not ideal.

@xanthio
Copy link
Contributor Author

xanthio commented May 12, 2024

OK I will do so !

@xanthio xanthio closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants