Code

Compiler Warnings Clean up#168

Code

Merged

Craftplacer merged 15 commits intoObsidianMC:masterObsidianMC/Obsidian:masterfrom HenryMigo:masterCopy head branch name to clipboardNov 4, 2021

+600-249

Commits

Commits on Oct 30, 2021

• Hide base member with 'new'

  HenryMigo

  committed
  fd01445

  Copy full SHA for fd01445

• Added nullable to base type and removed nullable from equals method

  HenryMigo

  committed
  f53ceea

  Copy full SHA for f53ceea

• Added full stop to some summaries

  HenryMigo

  committed
  99533db

  Copy full SHA for 99533db

• nullability of reference types warning

  HenryMigo

  committed
  f3988d0

  Copy full SHA for f3988d0

• Added constructors to resolve non-null property part 1

  HenryMigo

  committed
  4df2fcd

  Copy full SHA for 4df2fcd

• Some compiler warning fixes

  HenryMigo

  committed
  b83bf9b

  Copy full SHA for b83bf9b

• Fix for constructure initiation

  HenryMigo

  committed
  9ffdc8d

  Copy full SHA for 9ffdc8d

• Addressed couple hunderd warnings, 3692 relate to XML out of the 3708 total. 16 are other warnings.

  HenryMigo

  committed
  8f13d29

  Copy full SHA for 8f13d29

Commits on Oct 31, 2021

• PR Comments

  HenryMigo

  committed
  281190c

  Copy full SHA for 281190c

• Changed Name in ItemMetaBuilder back to normal (Warning will return)

  HenryMigo

  committed
  f134163

  Copy full SHA for f134163

Commits on Nov 1, 2021

• Further PR Comments

  HenryMigo

  committed
  285b7d7

  Copy full SHA for 285b7d7

Commits on Nov 2, 2021

• Additional PR comments

  HenryMigo

  committed
  9658bd4

  Copy full SHA for 9658bd4

• Changed to sync which returns task

  HenryMigo

  committed
  bacb05e

  Copy full SHA for bacb05e

Commits on Nov 4, 2021

• PR Comment for constructor on PluginAttribute.cs

  HenryMigo

  committed
  9aacdbc

  Copy full SHA for 9aacdbc

• Made properties nullable that are not in constructor

  HenryMigo

  committed
  6dbc8c6

  Copy full SHA for 6dbc8c6