-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(0.5.0) Updated sediment to work with all grids and model types #127
Conversation
…model types + added tests
Think this is probably the most straightforward way to set this up, and in this case the bottom cell only has to be calculated once |
I think in the same vein it may be worth modifying PAR integration to only integrate down to the bottom cell since a lot of the globe doesn't reach the bottom of the underlying grid (and at the moment I think we integrate it for the land area too) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 63.82% 63.58% -0.24%
==========================================
Files 28 28
Lines 1020 1049 +29
==========================================
+ Hits 651 667 +16
- Misses 369 382 +13
☔ View full report in Codecov by Sentry. |
Since it's just the codecov failing (and I'm not bothered by the lines in the NPZD model it says aren't being tested as it's just a warning and function no one will probably ever use) I'm happy for this PR to be merged now |
The example was failing because I'd changed the sediment models to only use flat fields, but we can't output these still due to CliMA/Oceananigans.jl#2770 which I've not fixed yet |
Nonhydrostatic + RK3 is not getting tested but it should |
This PR makes sediment models work with immersed boundary grids and improves sediment testing on all grid and model types.
This breaks the sediment, nitrogen/carbon flux, and sinking flux APIs.