chore: 🍰 Implement Use Of package.json 'Version' Etc. For Build And Refine Helm Chart

[Tirokk]

🛠 Refactor

Implement use of package.json 'version' etc. for '$ docker build …‘

Fixes #7

Todo

Docker image building

• use package.json version and build-number to select the ocelot.social version
  • Neo4j
  • backend
  • webapp
  • maintenance
• same for the Docker organisations as source and to push to
  • Neo4j
  • backend
  • webapp
  • maintenance
• add Neo4j to the Docker images

Helm Deployment

• set ocelot.social version
  • is set with the charts appVersion
• set Docker source organisation
  • is set with the values of each apps DOCKER_IMAGE_REPO
  • may this can be more centralised and not separate for all images? But not sure this is necessary …
• pull correct Neo4j image (community)

Open questions

• has the Chart.Version to be changed?

For Curiosity

• why a values.yaml.dist instead just values.yaml?

[Tirokk]

Do I have to merge or push this to master to test? @ulfgebhardt

[ulfgebhardt]

Do I have to merge or push this to master to test? @ulfgebhardt

To test you can change the on: condition on top of the file. E.g. remove the branch: master condition so it runs on every branch

[Tirokk]

Yeah. To change the on condition I was the idea I was woken up with this morning. 😄

[ulfgebhardt]

Job requirement not correct:

needs: [build_branded_backend,build_branded_webapp,build_branded_maintenance]
needs: [build_production_neo4j,build_branded_backend,build_branded_webapp,build_branded_maintenance]

See

Ocelot-Social-Deploy-Rebranding/.github/workflows/publish.yml

Line 184 in 050d0c3

needs: [build_branded_backend,build_branded_webapp,build_branded_maintenance]

[Tirokk]

Good seen @ulfgebhardt 👍🏼

[ulfgebhardt]

Suggested change

	# Copy public constants to the docker image and branding it
	# Copy public constants to the docker image branding it

[ulfgebhardt]

... to the docker image branding it
... in das docker image um es zu branden
or
... to the docker image and brand it
... in das docker image und brande es

I use the first because it describes that when you copy stuff like this to the docker image it becomes branded that way. The second sentence indicates that the copying and the branding are two separate processes which are done independently.

[Tirokk]

Ah, okay 👍🏼
I’ll do later

[Tirokk]

I would suggest:
kopiere öffentliche Konstanten in das Docker-Image, um es zu brandmarken (brandmarken is the closest in german 😂)
copy public constants into the Docker image to brand it (says Deepl)

[ulfgebhardt]

Suggested change

	# Copy public constants to the docker image and branding it
	# Copy public constants to the docker image branding it

[Tirokk]

same same @ulfgebhardt

[ulfgebhardt]

Suggested change

	# Copy public constants to the docker image and branding it
	# Copy public constants to the docker image branding it

[Tirokk]

same same @ulfgebhardt

[Tirokk]

I refined some of the comments and the default Docker image names I've seen now to be not perfect. @ulfgebhardt

In the comments with # label is appended based on .Chart.appVersion I left the two-spaced indent, because you did it right by indicating that this line belongs to the comment above, in my opinion.

[ulfgebhardt]

<3 awesome!