Updated OctoLight API information #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated OctoLight API information - Added notification regarding older version of OctoLight as it changes the API
- Missing spaces caused a build error?
|
Would it be easier to keep the API documentation just on your plugin's GitHub readme, and just provide a link from the plugin repository? That should save you making lots of PRs here if you want to change the docs (even small corrections you might find) in the future? |
|
Honestly, I don't see it changing much beyond this but you have a point, if you would prefer I do that then let me know and I will change the file straight way. |
- Removed API info - Setup link to GH page - Updated link to cleaner link
|
@cp2004, thanks for the suggestion, thinking about it, I think you have a point. The change is done. |
|
hmm...we've never had plugin notices outside of plugin adoption ones before. Need @foosel input on this one. |
- Removed added notification
|
Sorry for the delay, I removed the notification addition. |
jneilliii
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if this is not a good use of the
noticesfile as I am OK if it shouldn't be used in this way.Thank you.