-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new file: _plugins/filamentmotionsensor.md #1315
Conversation
new file: assets/img/plugins/filamentmotionsensor/settings.png new file: assets/img/plugins/filamentmotionsensor/sidebar.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few spots in your repo that needs to be adjusted to where the plugin_identifier hasn't been updated from the original...
plugin_idnetifier needs to be updated to filamentmotionsensor
to match the id here in the registry.
https://github.com/tabahi/Octoprint-Filament-Motion-Sensor/blob/d926f7cbad44a83a35ed6756eaaa29a25977e042/setup.py#L8
update hook needs to also be updated to return the plugin_identifier filamentmotionsensor
instead of smartfilamentsensor
, new user, and new repo name, and pip url.
https://github.com/tabahi/Octoprint-Filament-Motion-Sensor/blob/d926f7cbad44a83a35ed6756eaaa29a25977e042/filamentmotionsensor/__init__.py#L394-L422
Hit me up in Discord if you have any specific questions.
modified: assets/img/plugins/filamentmotionsensor/settings.png modified: assets/img/plugins/filamentmotionsensor/sidebar.png
Should be installable now. One big requirement is python >3.8 |
Thanks for those plugin_identifier fixes, one small thing, I think the user property is case sensitive in the update check, so should be |
Oh, and on your plugin repo you need to create a release with a tag that matches the version number in setup.py. https://github.com/tabahi/Octoprint-Filament-Motion-Sensor/releases |
@jneilliii How is it looking now? |
The old smart sensor plugin by Royrdan stopped working with the new updates. I have revised the plugin to make it functional again and added new features. There will be more updates soon.