Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new file: _plugins/filamentmotionsensor.md #1315

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

tabahi
Copy link
Contributor

@tabahi tabahi commented Aug 11, 2024

The old smart sensor plugin by Royrdan stopped working with the new updates. I have revised the plugin to make it functional again and added new features. There will be more updates soon.

new file:   assets/img/plugins/filamentmotionsensor/settings.png
new file:   assets/img/plugins/filamentmotionsensor/sidebar.png
Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few spots in your repo that needs to be adjusted to where the plugin_identifier hasn't been updated from the original...

plugin_idnetifier needs to be updated to filamentmotionsensor to match the id here in the registry.
https://github.com/tabahi/Octoprint-Filament-Motion-Sensor/blob/d926f7cbad44a83a35ed6756eaaa29a25977e042/setup.py#L8

update hook needs to also be updated to return the plugin_identifier filamentmotionsensor instead of smartfilamentsensor, new user, and new repo name, and pip url.
https://github.com/tabahi/Octoprint-Filament-Motion-Sensor/blob/d926f7cbad44a83a35ed6756eaaa29a25977e042/filamentmotionsensor/__init__.py#L394-L422

Hit me up in Discord if you have any specific questions.

@tabahi
Copy link
Contributor Author

tabahi commented Aug 11, 2024

Should be installable now. One big requirement is python >3.8

@jneilliii
Copy link
Contributor

Thanks for those plugin_identifier fixes, one small thing, I think the user property is case sensitive in the update check, so should be tabahi here.

@jneilliii
Copy link
Contributor

Oh, and on your plugin repo you need to create a release with a tag that matches the version number in setup.py.

https://github.com/tabahi/Octoprint-Filament-Motion-Sensor/releases

@tabahi
Copy link
Contributor Author

tabahi commented Aug 12, 2024

@jneilliii How is it looking now?

@jneilliii jneilliii merged commit dc3819d into OctoPrint:gh-pages Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants