Orion/create release 2 #48
Conversation
…mmit through to the fake server
| if selectedProject.PersistenceSettings.GetType() == "VersionControlled" && options.GitReference != "" || options.GitCommit != "" { | ||
| // it's a config-as-code project, we need to ask for Git Ref or Commit | ||
|
|
||
| } |
There was a problem hiding this comment.
Yuck. We should fix this in the Go API client somehow. But I understand why you're doing it. 😄
There was a problem hiding this comment.
The "PersistenceSettings.GetType() == "VersionControlled"" magic string bit?
That seemed to be how the go API client was doing it, so I copied from there. We could use type aliased strings like AccountType does? That seems to be the closest equivalent Go has to enums?
I'll file an issue against the Go API Client for this
There was a problem hiding this comment.
I'm wondering if there's a way we can hide this; put a better veneer on it.
I built this support for CaC back when it was available as an EAP. I kept them as strings in case things changed. Perhaps it's time to re-visit.
There was a problem hiding this comment.
OK, I'll create the issue and we can have the discussion over there
There was a problem hiding this comment.
Issue filed:
chore: Splits unit and integration tests into two workflows. Integration runs nightly, unit runs on every push
refactor: Cover release create workflow with unit tests mocking out the octopus server
feat: release create supports --git-commit and --git-ref on the command line