Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DAC docs and keyset generation docs #1340

Closed
wants to merge 7 commits into from
Closed

Conversation

Jason-W123
Copy link
Contributor

This pr includes:

  • Add keyset generation reference link to DAC getting started docs.
  • Add set-keyset in Orbit sdk example to keyset generation docs.

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-docs ✅ Ready (Inspect) Visit Preview Feb 20, 2025 7:45pm

@TucksonDev
Copy link
Contributor

Nice, thanks @Jason-W123 ! I had this one pending for a while. Can you also move the file to the same directory as the other pages in that section and adjust the links? 🙏

Copy link
Contributor

@anegg0 anegg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

@pete-vielhaber
Copy link
Contributor

I went to resolve merge conflicts and it appears the content was modified since the original PR in a manner in which I cannot determine the correct resolution; checking with the Orbit restructure folks to see what action we should take.

@Jason-W123 Jason-W123 mentioned this pull request Feb 21, 2025
@Jason-W123
Copy link
Contributor Author

I recreate a new pr for this: #2098, another fix is already merged in, so just need to add orbit sdk reference.

@Jason-W123 Jason-W123 closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants