Updated

OffchainLabs · Oct 15, 2024 · ac5b73c · ac5b73c
1 parent 5ea3124
commit ac5b73c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/src/lib/assetBridger/erc20Bridger.ts b/src/lib/assetBridger/erc20Bridger.ts
@@ -75,12 +75,12 @@ import { defaultAbiCoder } from 'ethers/lib/utils'
 import { OmitTyped, RequiredPick } from '../utils/types'
 import { RetryableDataTools } from '../dataEntities/retryableData'
 import { EventArgs } from '../dataEntities/event'
+import { ParentToChildMessageGasParams } from '../message/ParentToChildMessageCreator'
 import {
   getNativeTokenDecimals,
   isArbitrumChain,
   scaleToNativeTokenDecimals,
 } from '../utils/lib'
-import { ParentToChildMessageGasParams } from '../message/ParentToChildMessageCreator'
 import { L2ERC20Gateway__factory } from '../abi/factories/L2ERC20Gateway__factory'
 import { getErc20ParentAddressFromParentToChildTxRequest } from '../utils/calldata'
 
@@ -1128,7 +1128,7 @@ export class AdminErc20Bridger extends Erc20Bridger {
       const data = parentToken.interface.encodeFunctionData(
         'registerTokenOnL2',
         [
-          parentTokenAddress,
+          childTokenAddress,
           setTokenGas.maxSubmissionCost,
           setGatewayGas.maxSubmissionCost,
           setTokenGas.gasLimit,

diff --git a/src/lib/message/ParentToChildMessageGasEstimator.ts b/src/lib/message/ParentToChildMessageGasEstimator.ts
@@ -237,7 +237,7 @@ export class ParentToChildMessageGasEstimator {
       childNetwork,
     })
 
-    // estimate the l1 gas price
+    // estimate the child gas price
     const maxFeePerGasPromise = this.estimateMaxFeePerGas(options?.maxFeePerGas)
 
     // estimate the submission fee

diff --git a/tests/integration/custom-fee-token/customFeeTokenEthBridger.test.ts b/tests/integration/custom-fee-token/customFeeTokenEthBridger.test.ts
@@ -30,9 +30,9 @@ import {
 } from '../testHelpers'
 
 import { describeOnlyWhenCustomGasToken } from './mochaExtensions'
-import { getNativeTokenDecimals } from '../../../src/lib/utils/lib'
 import { ChildToParentMessageStatus } from '../../../src'
 import { ChildToParentMessage } from '../../../src/lib/message/ChildToParentMessage'
+import { getNativeTokenDecimals } from '../../../src/lib/utils/lib'
 
 dotenv.config()
 

diff --git a/tests/integration/eth.test.ts b/tests/integration/eth.test.ts
@@ -143,15 +143,7 @@ describe('Ether', async () => {
       childSigner.provider!
     )
 
-    const l1ToL2Messages = await rec.getEthDeposits(childSigner.provider!)
-    expect(l1ToL2Messages.length).to.eq(1, 'failed to find 1 l1 to l2 message')
-    const l1ToL2Message = l1ToL2Messages[0]
-
     const walletAddress = await parentSigner.getAddress()
-    expect(l1ToL2Message.to).to.eq(walletAddress, 'message inputs value error')
-    expect(l1ToL2Message.value.toString(), 'message inputs value error').to.eq(
-      parseEther(amount).toString()
-    )
 
     const parentToChildMessages = await rec.getEthDeposits(
       childSigner.provider!