chore: update childChain to childNetwork on public methods for bridgers #513
+95
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
douglance
commented
Jul 10, 2024
| @@ -34,12 +34,12 @@ export abstract class AssetBridger<DepositParams, WithdrawParams> { | |||
| /** | |||
| * In case of a chain that uses ETH as its native/gas token, this is either `undefined` or the zero address | |||
| * | |||
| * In case of a chain that uses an ERC-20 token from the parent chain as its native/gas token, this is the address of said token on the parent chain | |||
| * In case of a chain that uses an ERC-20 token from the parent network as its native/gas token, this is the address of said token on the parent network | |||
There was a problem hiding this comment.
I changed mentions of "parent chain" in comments to "parent network" as well because it read really strange most of the time when referring to parent chains and child networks.
spsjvc
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.