-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: set up monorepo #554
base: main
Are you sure you want to change the base?
Conversation
yarn.lock
Outdated
@@ -1,7 +1,6 @@ | |||
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
# yarn lockfile v1 | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm how did this end up here? can you revert it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was using this to break the cache. fixed 88b994a
@@ -87,9 +50,6 @@ | |||
"typescript": "^4.9.5", | |||
"yargs": "^17.3.1" | |||
}, | |||
"files": [ | |||
"dist/**/*" | |||
], | |||
"resolutions": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move resolutions for runtime dependencies to the package's package.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking it would be nice to have them shared among packages, but I guess it's probably better to just deal with issues individually if they come up. so i moved the resolutions down to the sdk
package 88b994a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh actually, those are all there for audit-ci fixing purposes, so we want them there c80b628
import * as path from 'path' | ||
|
||
export const loadEnv = () => { | ||
dotenv.config({ path: path.resolve(__dirname, '../../../../../.env') }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work properly both in the case when you're running commands at the root level of the monorepo, and when you cd into the package and run it there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does work from both locations. __dirname
is the location of this file.
packages/sdk
and move its unique config therescripts
folder in a future PR