feat: custom orbit pages #1732
Merged
feat: custom orbit pages #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dewanshparashar
changed the title
spsjvc
reviewed
Jul 4, 2024
| import { getBridgeUiConfigForChain } from '../util/bridgeUiConfig' | ||
| import { useNetworks } from './useNetworks' | ||
|
|
||
| export const useDestinationOrbitChain = () => { |
There was a problem hiding this comment.
Suggested change
| export const useDestinationOrbitChain = () => { | |
| export const useDestinationChainStyles = () => { |
Comment on lines
23
to
24
| chain: orbitChain, | ||
| styles: orbitStyles |
There was a problem hiding this comment.
we don't really need the chain here, we can return only the styles object, and it can be empty when no chain detected
| const [defaultSourceChainId] = getDestinationChainIds(destinationChainId) | ||
| return { | ||
| sourceChainId: | ||
| getTeleportChainIdForOrbitChain(destinationChainId) ?? // show the grand-parent-chain id if valid, else get the parent chain id |
There was a problem hiding this comment.
I'd rather we default to L2 being source here, that's the flow that gets more usage
There was a problem hiding this comment.
yah sgtm to default to Arb One -> L3 instead of Ethereum -> L3
…e into feat-custom-orbit-pages-v2
dewanshparashar
requested review from
spsjvc and
yermakova
and removed request for
yermakova
spsjvc
reviewed
Jul 10, 2024
| ) | ||
|
|
||
| // early return if the orbit chain is not found | ||
| if (!orbitChain) return undefined |
There was a problem hiding this comment.
return empty object here, that way it can still work as a style prop
| import { getBridgeUiConfigForChain } from '../util/bridgeUiConfig' | ||
| import { useNetworks } from './useNetworks' | ||
|
|
||
| export const useDestinationChainStyles = () => { |
There was a problem hiding this comment.
nit to rename to style as that's the dom prop it will be passed to
Suggested change
| export const useDestinationChainStyles = () => { | |
| export const useDestinationChainStyle = () => { |
spsjvc
approved these changes
Jul 26, 2024
chrstph-dvx
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-608