fix: Fix useBalance delay when switching networks #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrstph-dvx
force-pushed
the
fs-652-fix-useBalanceOnSourceChain-hook
branch
from
4d3c52b to
98f6e67
Compare
chrstph-dvx
requested review from
fionnachan and
dewanshparashar
and removed request for
fionnachan
fionnachan
reviewed
Jul 18, 2024
packages/arb-token-bridge-ui/src/hooks/useBalanceOnSourceChain.ts
Outdated
Show resolved
Hide resolved
fionnachan
reviewed
Jul 19, 2024
| @@ -82,54 +87,8 @@ describe('useBalance', () => { | |||
| expect(erc20Balances).toBeNull() | |||
| }) | |||
|
|
|||
| it('getter return null for missing chainId', async () => { | |||
There was a problem hiding this comment.
It became invalid after the changes in useBalance. We accept chainId, not provider anymore
chrstph-dvx
changed the title
fionnachan
previously approved these changes
Jul 19, 2024
| 1 | ||
| ) | ||
| jest.mock('../../token-bridge-sdk/utils', () => ({ | ||
| getProviderForChainId: function A() { |
There was a problem hiding this comment.
What's function A?
Can't we just use anonymous function () => provider here?
There was a problem hiding this comment.
100% yes, it's a leftover from debug (I would probably rename it to getProviderForChainIdMock rather than use anonymous function, it's easier to debug
dewanshparashar
approved these changes
Jul 19, 2024
fionnachan
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have an issue when user would switch source network from network A to network B, and balance from
useBalanceOnSourceChainwould be the balance on network A for a second. This led touseGasEstimatecall despite the balance check.Steps to test