ci: move out build run #1926
Merged
ci: move out build run #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
commented
Sep 26, 2024
| name: Cache build artifacts | ||
|
|
||
| on: | ||
| workflow_call: |
There was a problem hiding this comment.
this is a reusable workflow, not a composite workflow
https://docs.github.com/en/actions/sharing-automations/reusing-workflows
Comment on lines
+20
to
+26
| - name: Check cache for build artifacts | ||
| id: cache | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: | | ||
| ./packages/arb-token-bridge-ui/build | ||
| key: build-artifacts-${{ github.run_id }} |
There was a problem hiding this comment.
we try to find it from cache first, and if it's not there, then we run build, otherwise just use the cache
this is similar to the approach we use for node modules in our actions repo
Comment on lines
+30
to
+33
| build: | ||
| name: 'Build' | ||
| uses: ./.github/workflows/build.yml | ||
| secrets: inherit |
There was a problem hiding this comment.
moved into here
and now the build won't be run twice ever on the same run
fionnachan
commented
Sep 26, 2024
|
|
||
| - name: Start UI and Test | ||
| run: yarn start-server-and-test 'start' http://127.0.0.1:3000 'yarn test:ci' | ||
|
|
||
| audit: | ||
| name: "Audit" | ||
| runs-on: ubuntu-latest | ||
| needs: build |
There was a problem hiding this comment.
it never needed the build files
chrstph-dvx
previously approved these changes
Oct 17, 2024
douglance
previously approved these changes
Oct 18, 2024
fionnachan
dismissed stale reviews from douglance and chrstph-dvx
via
5a83cad
douglance
previously approved these changes
Oct 22, 2024
chrstph-dvx
previously approved these changes
Oct 22, 2024
fionnachan
dismissed stale reviews from chrstph-dvx and douglance
via
780179e
chrstph-dvx
approved these changes
Oct 22, 2024
douglance
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-871