feat: support withdrawal claim from any wallet #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const { chain } = useNetwork() | ||
| const { switchNetworkAsync } = useSwitchNetworkWithConfig() | ||
| const networkName = getNetworkName(chain?.id ?? 0) | ||
| const { sanitizedAddress } = useTransactionHistoryAddressStore() | ||
|
|
||
| const viewingAnotherAddress = | ||
| connectedAddress && | ||
| sanitizedAddress && |
There was a problem hiding this comment.
NIT: Wouldn't it be better to rename the addresses to searchedAddress and connectedAddress, since that's more apt?
Comment on lines
180
to
183
| sanitizedAddress && | ||
| connectedAddress && | ||
| sanitizedAddress.toLowerCase() !== connectedAddress.toLowerCase() | ||
| } |
There was a problem hiding this comment.
Replace it with viewingAnotherAddress
dewanshparashar
previously approved these changes
Dec 13, 2024
douglance
reviewed
Dec 13, 2024
packages/arb-token-bridge-ui/src/components/TransactionHistory/TransactionsTableRowAction.tsx
Show resolved
Hide resolved
| const { sanitizedAddress: searchedAddress } = | ||
| useTransactionHistoryAddressStore() | ||
|
|
||
| const viewingAnotherAddress = |
There was a problem hiding this comment.
Suggested change
| const viewingAnotherAddress = | |
| const isViewingAnotherAddress = |
dewanshparashar
approved these changes
Dec 17, 2024
douglance
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-1036