feat: fetch tx history sequentially #2141
Draft
+571
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
commented
Dec 16, 2024
| @@ -241,101 +259,65 @@ function dedupeTransactions(txs: Transfer[]) { | |||
| ) | |||
| } | |||
|
|
|||
| async function getUpdatedPendingTransaction(tx: MergedTransaction) { | |||
There was a problem hiding this comment.
Moved outside the hook because it's used by both sender and receiver fetchers
brtkx
commented
Dec 16, 2024
| const { chain } = useNetwork() | ||
| const [isTestnetMode] = useIsTestnetMode() | ||
| const { isSmartContractWallet, isLoading: isLoadingAccountType } = | ||
| useAccountType() | ||
|
|
||
| // Check what type of CCTP (deposit, withdrawal or all) to fetch |
There was a problem hiding this comment.
CCTP moved to its own hook
brtkx
commented
Dec 16, 2024
| useSWRImmutable<ChainPair[]>( | ||
| address ? ['failed_chain_pairs', address] : null | ||
| ) | ||
| const { data: erroredChains, mutate: addErroredChain } = useSWRImmutable< |
There was a problem hiding this comment.
erroredChains are renamed from failedChainPairs imo it's less of a mouthful
brtkx
changed the title
brtkx
changed the title
fionnachan
reviewed
Dec 17, 2024
| <div className="flex h-[28px] items-center space-x-2"> | ||
| <FailedChainPairsTooltip failedChainPairs={failedChainPairs} /> | ||
| <FailedChainPairsTooltip failedChainPairs={rawDataErroredChains} /> |
There was a problem hiding this comment.
the property is still called failedChainPairs
we should update it??
There was a problem hiding this comment.
i think we should split some hooks under a folder called /transactionHistoryHooks/ or split the hooks into several files
it's too chunky right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes FS-1054
The goal of these changes is to fetch sender transactions first, and once it's done and we display them we fetch receiver transactions.
Change log:
useTransactionHistoryupdated to include individual data for sender and receiver, so we can track states (such as loading) for each of themuseTransactionHistoryWithoutStatusesrenamed touseRawTransactionHistoryuseCctpTransactions,useMappedSenderTransactionHistoryanduseMappedReceiverTransactionHistory, all of which returnMergedTransaction[]failedChainPairsrenamed torawDataErroredChainsgetUpdatedPendingTransactionmoved outside the hook and is reused in different hooks