Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear stale pending tx #913

Closed
wants to merge 6 commits into from
Closed

Conversation

fionnachan
Copy link
Member

Steps to test

  1. on production, edit arbTransactions in your local storage to have a tx created >7 days ago with the "pending" status
  2. note that you see the pending tx card on tx history panel
  3. on this branch, use the same arbTransactions
  4. note that the pending tx card should not exist on the tx history panel

If some pending txs are created <7 days, the stale pending txs will still stay.
This PR only implements clearing if all pending txs are created >7 days.

Closes #837

@cla-bot cla-bot bot added the cla-signed label Jun 5, 2023
@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-token-bridge ✅ Ready (Inspect) Visit Preview Jun 20, 2023 4:53pm

@chrstph-dvx chrstph-dvx self-requested a review June 6, 2023 08:40
@fionnachan fionnachan marked this pull request as ready for review June 20, 2023 16:45
@fionnachan
Copy link
Member Author

closing this for now
#985 and #986 are more elegant solutions

@fionnachan fionnachan closed this Jun 21, 2023
@fionnachan fionnachan deleted the clear-stale-pending-tx branch June 21, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI bug: stuck pending card on tx history panel when transaction is replaced
2 participants