Add CI for testnode that starts up nitro test node and rans l2 transa… #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsahee
requested changes
Feb 20, 2024
test-node.bash
Outdated
| @@ -38,6 +38,7 @@ l3_token_bridge=false | |||
| batchposters=1 | |||
| devprivkey=b6b15c8cb491557369f3c7d2c287b053eb229daa9c22138887752191c9520659 | |||
| l1chainid=1337 | |||
| runL2Txs=false | |||
There was a problem hiding this comment.
I prefer not to add options here if we can avoid it.. already messy enough
.github/workflows/testnode.bash
Outdated
| # The script starts up the test node (with timeout 1 minute), with option to | ||
| # run l2 transactions to make sure node is working | ||
|
|
||
| timeout 60 ${{ github.workspace }}/nitro-testnode/test-node.bash --init --dev || exit_status=$? |
There was a problem hiding this comment.
this doesn't use runl2Txs
Also - better if we can have all relevant logic here.
you can:
- add --detach when first callinf test-node
- wait for a little with sleep
- call e.g. test-node.sh script send-l2 --ethamount 100 --to user_l2user --wait
|
Moved this to new pull request |
Ferret-san
pushed a commit
to celestiaorg/nitro-testnode
that referenced
this pull request
Aug 27, 2024
…ners Add CODEOWNERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctions