Decouple nitro-contracts from nitro #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
reviewed
Apr 22, 2024
gzeoneth
reviewed
Apr 22, 2024
'e2e-to-ci' implements support for testnode to use custom nitro-contracts branches Once 'e2e-to-ci' is in master, 'NITRO_CONTRACTS_BRANCH' env var can be removed from CI
godzillaba
approved these changes
Apr 23, 2024
Ferret-san
pushed a commit
to celestiaorg/nitro-testnode
that referenced
this pull request
Aug 27, 2024
…patible Fix running a simple nitro node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR enables using custom nitro-contracts and token-bridge-contracts versions in testnode.
So far, nitro-contracts version depended on the pinned nitro-contracts commit in nitro. And Go deployer was used to deploy the chains. Now that's replaced with a script in nitro-contracts which will do equivalent - deploy RollupCreator, deploy rollup and store configs and addresses.
Versions are provided via
NITRO_CONTRACTS_BRANCHandTOKEN_BRIDGE_BRANCHenv vars