Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update blockscout pin #53

Merged
merged 1 commit into from
May 18, 2024
Merged

update blockscout pin #53

merged 1 commit into from
May 18, 2024

Conversation

tsahee
Copy link
Collaborator

@tsahee tsahee commented May 7, 2024

edit ArbABI

@tsahee tsahee changed the base branch from release to master May 7, 2024 01:30
@eljobe eljobe self-requested a review May 10, 2024 12:57
@eljobe
Copy link
Member

eljobe commented May 10, 2024

LGTM

eljobe
eljobe approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzeoneth
Copy link
Member

gzeoneth commented May 13, 2024 •
edited
Loading

Merging #54 to fix CI

CI looks weird, it prints Using NITRO_CONTRACTS_BRANCH: which does not exists in this branch; maybe because it was based on release instead of master before? trigger a rerun to debug

edit: it looks like there are some caching issue in the ci build process
ci run on the same commit
https://github.com/OffchainLabs/nitro-testnode/actions/runs/8978252327/job/24896182906
https://github.com/OffchainLabs/nitro-testnode/actions/runs/9062518761/job/24896557950
notice the 2 runs are different with the Using NITRO_CONTRACTS_BRANCH: logs
I have to trigger cache invalidation by opening a new PR and now CI pass

@tsahee tsahee merged commit 31c4a2c into master May 18, 2024
1 of 2 checks passed
@tsahee tsahee deleted the blockscout_pin branch May 18, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsahee @eljobe @gzeoneth