Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use node v18 #67

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: use node v18 #67

merged 1 commit into from
Jul 8, 2024

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Jul 4, 2024

Node.js 16 reached end of life on September 11, 2023, we are deprecating v16 support in nitro-contracts and other repo. This PR bump nodejs to v18 in the container base images.

@gzeoneth gzeoneth requested review from gvladika and tsahee July 4, 2024 08:48
gvladika
gvladika previously approved these changes Jul 4, 2024
Copy link
Contributor

@gvladika gvladika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gzeoneth gzeoneth changed the base branch from master to release July 4, 2024 09:04
@gzeoneth gzeoneth dismissed gvladika’s stale review July 4, 2024 09:04

The base branch was changed.

@gzeoneth gzeoneth requested a review from gvladika July 4, 2024 09:04
@tsahee tsahee merged commit b162ff9 into release Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants