-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace inline code samples with snippets #292
Conversation
Learn Build status updates of commit bad9934: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 4ed75ee: ✅ Validation status: passedFor more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - a couple of style choices, but just want to make sure that the nested snippets aren't shown in the outer snippet when extracted to the docs
samples/spreadsheet/retrieve_a_list_of_the_worksheets/cs/Program.cs
Outdated
Show resolved
Hide resolved
samples/spreadsheet/retrieve_a_list_of_the_worksheets/cs/Program.cs
Outdated
Show resolved
Hide resolved
theSheets = document?.WorkbookPart?.Workbook.Sheets; | ||
// </Snippet5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this look for snippet 4? does it remove the Snippet5 comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the tags remove all other tags as well as themselves. That's why the last sample showing the complete code has to be in a surrounding all the code, if you just point the sample at the whole file then the comments showing the tags are not removed.
in the future, it will be helpful to have the title include the sample it's reworking |
…am.cs Co-authored-by: Taylor Southwick <[email protected]>
…am.cs Co-authored-by: Taylor Southwick <[email protected]>
…am.cs Co-authored-by: Taylor Southwick <[email protected]>
Learn Build status updates of commit c807325: ✅ Validation status: passedFor more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #282 , closes #283