-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 feat(server.ts): change port variable case from lowercase port to u… #224
🚀 feat(server.ts): change port variable case from lowercase port to u… #224
Conversation
…ppercase PORT to improve semantics 🚀 feat(server.ts): add support for process.env.PORT environment variable to be able to run app on a configurable port 🚀 feat(revealDelayedContract.ts): add new file revealDelayedContract.ts to handle the action of revealing a delayed contract 🚀 feat(EventPassCardFooter.tsx): import EventPassNftContractType_Enum from @gql/shared/types to use in the component 🚀 feat(EventPassCardFooter.tsx): add EventPassContractRevealButtonClient component to render a button for revealing the contract if it's of type DelayedReveal and not yet revealed 🚀 feat(EventPassContractRevealButtonClient.tsx): add new file EventPassContractRevealButtonClient.tsx to handle the action of revealing a delayed contract 🚀 feat(EventPassNftFilesTable/examples.tsx): add isDelayedRevealed property to eventPassNftVIPWithContract example 🚀 feat(EventSheet.stories.tsx): import revealDelayedContract action and add mock for it, add WithEventPassDelayedRevealToReveal story to test the reveal button functionality 🚀 feat(EventSheet/examples.tsx): add isDelayedRevealed property to eventWithDelayedPasses example 🚀 feat(event.query.gql): add isDelayedRevealed field to eventPass object in GetEventWithPassesOrganizer query 🚀 feat(en.json): add translations for EventPassContractRevealButtonClient component 🚀 feat(fr.json): add translations for EventPassContractRevealButtonClient component
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Description updated to latest commit (fe859a1) |
PR Analysis
PR Feedback
How to useInstructions
|
…s undefined to prevent unexpected behavior 🐛 fix(nft-thirdweb-api.ts): throw an error if event pass NFT contract is not found for the given address to handle the case when the contract does not exist or is not accessible
… improve code cleanliness and readability 🔧 fix(index.spec.ts): mock isBackOffice function to return the correct value in test cases to ensure accurate testing 🔧 fix(index.spec.ts): remove unnecessary environment variable assignment in test case to improve test clarity and accuracy
…ariable in test cases
… for consistency with nx.json 🔧 chore(nx.json): update cacheDirectory value to /tmp/nx-cache for consistency with .env.local
…_size to 8192 for better memory allocation during build and e2e tests
…prove readability and remove unnecessary file creation
Type
enhancement
Description
revealDelayedContract
that uses theNftClaimable
SDK to reveal a delayed contract.EventPassCardFooter.tsx
to render theEventPassContractRevealButtonClient
if the event pass type isDelayedReveal
and not yet revealed.EventPassContractRevealButtonClient.tsx
to handle the action of revealing a delayed contract.isDelayedRevealed
property toeventPassNftVIPWithContract
andeventWithDelayedPasses
examples.GetEventWithPassesOrganizerQuery
type and query to includeisDelayedRevealed
field ineventPassNftContract
.EventPassContractRevealButtonClient
component in English and French.PR changes walkthrough
8 files
revealDelayedContract.ts
libs/features/back-office/events/src/lib/actions/revealDelayedContract.ts
Added a new function
revealDelayedContract
that uses theNftClaimable
SDK to reveal a delayed contract.EventPassCardFooter.tsx
libs/features/back-office/events/src/lib/molecules/EventPassCardFooter/EventPassCardFooter.tsx
Imported
EventPassNftContractType_Enum
andEventPassContractRevealButtonClient
. Added a new conditionto render the
EventPassContractRevealButtonClient
if theevent pass type is
DelayedReveal
and not yet revealed.EventPassContractRevealButtonClient.tsx
libs/features/back-office/events/src/lib/molecules/EventPassCardFooter/EventPassContractRevealButtonClient.tsx
Added a new file
EventPassContractRevealButtonClient.tsx
to handle the action of revealing a delayed contract. It
includes a button for revealing the contract and error
handling.
examples.tsx
libs/features/back-office/events/src/lib/molecules/EventPassNftFilesTable/examples.tsx
Added
isDelayedRevealed
property toeventPassNftVIPWithContract
example.examples.tsx
libs/features/back-office/events/src/lib/organisms/EventSheet/examples.tsx
Added
isDelayedRevealed
property toeventWithDelayedPasses
example.index.ts
libs/gql/admin/api/src/generated/index.ts
Added
isDelayedRevealed
field toeventPass
object inGetEventWithPassesOrganizerQuery
.index.ts
libs/gql/admin/types/src/generated/index.ts
Updated
GetEventWithPassesOrganizerQuery
type to includeisDelayedRevealed
field ineventPassNftContract
.event.query.gql
libs/gql/admin/api/src/queries/organizer/event/event.query.gql
Added
isDelayedRevealed
field toeventPassNftContract
inthe
GetEventWithPassesOrganizer
query.1 files
EventSheet.stories.tsx
libs/features/back-office/events/src/lib/organisms/EventSheet/EventSheet.stories.tsx
Imported
revealDelayedContract
action and added a mock forit. Added a new story
WithEventPassDelayedRevealToReveal
to test the reveal button functionality.
2 files
en.json
libs/next/i18n/src/messages/en.json
Added translations for
EventPassContractRevealButtonClient
component in English.
fr.json
libs/next/i18n/src/messages/fr.json
Added translations for
EventPassContractRevealButtonClient
component in French.
User description
…ppercase PORT to improve semantics
🚀 feat(server.ts): add support for process.env.PORT environment variable to be able to run app on a configurable port
🚀 feat(revealDelayedContract.ts): add new file revealDelayedContract.ts to handle the action of revealing a delayed contract
🚀 feat(EventPassCardFooter.tsx): import EventPassNftContractType_Enum from @gql/shared/types to use in the component
🚀 feat(EventPassCardFooter.tsx): add EventPassContractRevealButtonClient component to render a button for revealing the contract if it's of type DelayedReveal and not yet revealed
🚀 feat(EventPassContractRevealButtonClient.tsx): add new file EventPassContractRevealButtonClient.tsx to handle the action of revealing a delayed contract
🚀 feat(EventPassNftFilesTable/examples.tsx): add isDelayedRevealed property to eventPassNftVIPWithContract example
🚀 feat(EventSheet.stories.tsx): import revealDelayedContract action and add mock for it, add WithEventPassDelayedRevealToReveal story to test the reveal button functionality
🚀 feat(EventSheet/examples.tsx): add isDelayedRevealed property to eventWithDelayedPasses example
🚀 feat(event.query.gql): add isDelayedRevealed field to eventPass object in GetEventWithPassesOrganizer query
🚀 feat(en.json): add translations for EventPassContractRevealButtonClient component
🚀 feat(fr.json): add translations for EventPassContractRevealButtonClient component