Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCI-P3, DCI-P3+, and Display P3 #412

Merged
merged 5 commits into from
Aug 17, 2024
Merged

Add DCI-P3, DCI-P3+, and Display P3 #412

merged 5 commits into from
Aug 17, 2024

Conversation

Kirk-Fox
Copy link
Contributor

This pull request implements the DCI-P3, DCI-P3+, and Display P3 color spaces and standards.

Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #412 will improve performances by 20.29%

Comparing Kirk-Fox:master (068eccc) with master (fab4412)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark master Kirk-Fox:master Change
multiply_3x3 345.8 ns 287.5 ns +20.29%

Copy link
Owner

@Ogeon Ogeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I wanted to respond earlier, but I didn't find a good moment to sit down and have a proper look during the week.

The only real uncertainty from my part is the white point. I try to name constants and algorithms in a way that makes the origin clear. Sure, it's name spaced in this case, but it can easily escape out of context.

palette/src/encoding/p3.rs Outdated Show resolved Hide resolved
palette/src/lib.rs Outdated Show resolved Hide resolved
@Ogeon
Copy link
Owner

Ogeon commented Aug 17, 2024

Alright, cool, thanks a lot! Once again, I appreciate all the help

@Ogeon Ogeon merged commit 5476be6 into Ogeon:master Aug 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display P3 (and DCI-P3) support
2 participants