Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upcoming Clippy lifetime warnings #419

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Fix upcoming Clippy lifetime warnings #419

merged 1 commit into from
Oct 27, 2024

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Oct 27, 2024

Clarifies implicitly named lifetimes, and elides named lifetimes that only appear once. Shouldn't affect the type checking.

@Ogeon Ogeon added the internal An internal change that will not be shown in release notes label Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (e37e2fe) to head (d78e89d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
- Coverage   82.87%   82.83%   -0.04%     
==========================================
  Files         130      131       +1     
  Lines       20199    20162      -37     
  Branches    20199    20162      -37     
==========================================
- Hits        16739    16702      -37     
  Misses       3337     3337              
  Partials      123      123              
Components Coverage Δ
palette 82.90% <0.00%> (-0.04%) ⬇️
palette_derive 81.98% <ø> (ø)

Copy link

codspeed-hq bot commented Oct 27, 2024

CodSpeed Performance Report

Merging #419 will improve performances by 14.99%

Comparing clippy_fixes (d78e89d) with master (e37e2fe)

Summary

⚡ 2 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark master clippy_fixes Change
matrix_inverse 438.9 ns 381.7 ns +14.99%
multiply_3x3 316.7 ns 287.5 ns +10.14%

@Ogeon Ogeon merged commit 4a30161 into master Oct 27, 2024
17 of 20 checks passed
@Ogeon Ogeon deleted the clippy_fixes branch October 27, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal change that will not be shown in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant