Refactored Crate, v2.0.0 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fix on maximum candles allowed, updated to 350 from 300.
Merge pull request #4 from Ohkthx/develop
Introduced the Sandbox API. Changed Signer into HttpAgent, SecureHttpAgent, and PublicHttpAgent. Removed Utils API, replaced by Public API. UnixTime -> ServerTime. OrderSide required on order creation instead of `&str`. Removed recursive API calls and replaced with iterative calls.
Updated documentation for Portfolio, Sandbox, and Public API points. Updated documentation for additional added examples. Updated projects README documentation. Updated the JWT generation to remove outdated fields. Removed constants associated with old JWT requirements. Moved Balance from `account.rs` to `shared.rs`
Removed several `create_` order API endpoints, `create()` handles all now. Fixed order creation to work with newer API changes. Introduced new `Enums` for more control over order creation. Added documentation to parts of the Portfolio endpoints.
Added `client.order.close_position()` endpoint. Added Create Order Preview Endpoint (`client.order.preview_create`) Renamed `PreviewEditOrderResponse` to `EditOrderPreview` Added `preview(bool)` to the CreateOrderBuilder.
…nstances. Updated rate limits for REST and Websocket clients. Refactored all endpoints to use new error handling. Refactored many struct names for better clarity and aligment with API. Added additional error messages. Better error handling reported to the user. Updated docstrings for the Convert API.
…Client. Public and User endpoints updated. Support for multi-stream (readers) added. Renamed several key-functions to improve readability. `websocket` and `watch_candles` examples updated. Fixed a bug that prevented creating PublicRestClient. Split the massive `models/websocket.rs` into multiple files. Rewrote `Messages` to align with best practices. Moved key weboscket responses to the websocket module. Enhanced `task_tracker.rs` readability.
RestClientBuilder required to construct new RestClient. Fixed a bug with WebSocket User Endpoint. Custom deserialize for OrderType created to play nice with Order updates from WebSocket. Broke down `models/order.rs` into a sub module due to size. Made Queries and Requests that are purely Optional... Optional. Requests now have a Request Trait applied for validation. Created builders for all Requests and Queries. Enhanced the QueryBuilder. Renamed many Requests, Responses, and Queries to follow [Resource][Action][Type]. Removed custom deserializer for numeric types in favor of `serde_with` crate. Requests and Queries now include required fields in their `new()`. Defaults added for majority of Query and Requests. Renamed CbAdvError to CbError. All enums have `PartialEq` trait. Fixed UserEvent for WebSocket to include additional fields. `websocket_user` example added. Added websocket reconnection. Many user facing structs now have Serialize and Deserialize traits. Added more enums to various responses from the remote API.
Ohkthx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the crate to be compatible with the current Coinbase Advanced API. Many changes have happened since the last update which required the crate to be restructured for a better user experience.
Types of changes:
... and more!