position update refactorization

Oksydan · Jan 5, 2024 · f8251b8 · f8251b8
1 parent 02870a9
commit f8251b8
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 21 deletions.
diff --git a/config/admin/grid.yml b/config/admin/grid.yml
@@ -28,10 +28,3 @@ services:
     arguments:
       - '@oksydan.is_imageslider.grid.data.factory.image_slider_data_factory'
       - '@oksydan.is_imageslider.provider.image_provider'
-
-  oksydan.is_imageslider.grid.position_definition:
-    class: PrestaShop\PrestaShop\Core\Grid\Position\PositionDefinition
-    arguments:
-      - 'image_slider'
-      - 'id_slide'
-      - 'position'
diff --git a/src/Controller/ImagesliderController.php b/src/Controller/ImagesliderController.php
@@ -9,6 +9,7 @@
 use Oksydan\IsImageslider\Filter\ImageSliderFileters;
 use Oksydan\IsImageslider\Handler\Slide\DeleteSlideHandler;
 use Oksydan\IsImageslider\Handler\Slide\ToggleSlideActivityHandler;
+use Oksydan\IsImageslider\Handler\Slide\UpdateSliderPositionHandler;
 use Oksydan\IsImageslider\Repository\ImageSliderRepository;
 use Oksydan\IsImageslider\Translations\TranslationDomains;
 use PrestaShop\PrestaShop\Core\Form\FormHandlerInterface;
@@ -46,6 +47,8 @@ class ImagesliderController extends FrameworkBundleAdminController
 
     private ToggleSlideActivityHandler $toggleSlideActivityHandler;
 
+    private UpdateSliderPositionHandler $updateSliderPositionHandler;
+
     public function __construct(
         TemplateCache $templateCache,
         DeleteSlideHandler $deleteSlideHandler,
@@ -56,7 +59,8 @@ public function __construct(
         IdentifiableObjectFormHandlerInterface $imagesliderFormHandler,
         TranslatorInterface $translator,
         ImageSliderRepository $imageSliderRepository,
-        ToggleSlideActivityHandler $toggleSlideActivityHandler
+        ToggleSlideActivityHandler $toggleSlideActivityHandler,
+        UpdateSliderPositionHandler $updateSliderPositionHandler
     ) {
         parent::__construct();
         $this->templateCache = $templateCache;
@@ -69,6 +73,7 @@ public function __construct(
         $this->translator = $translator;
         $this->imageSliderRepository = $imageSliderRepository;
         $this->toggleSlideActivityHandler = $toggleSlideActivityHandler;
+        $this->updateSliderPositionHandler = $updateSliderPositionHandler;
     }
 
     public function index(ImageSliderFileters $filters): Response
@@ -246,19 +251,7 @@ public function toggleStatus(Request $request, int $slideId): Response
     public function updatePositionAction(Request $request): Response
     {
         try {
-            $positionsData = [
-                'positions' => $request->request->get('positions'),
-            ];
-
-            $positionDefinition = $this->get('oksydan.is_imageslider.grid.position_definition');
-
-            $positionUpdateFactory = $this->get('prestashop.core.grid.position.position_update_factory');
-            $positionUpdate = $positionUpdateFactory->buildPositionUpdate($positionsData, $positionDefinition);
-
-            $updater = $this->get('prestashop.core.grid.position.doctrine_grid_position_updater');
-
-            $updater->update($positionUpdate);
-            $this->clearTemplateCache();
+            $this->updateSliderPositionHandler->handle($request->request->get('positions'));
 
             $this->addFlash('success', $this->trans('Successful update.', 'Admin.Notifications.Success'));
         } catch (PositionDataException|PositionUpdateException $e) {

diff --git a/src/Handler/Slide/UpdateSliderPositionHandler.php b/src/Handler/Slide/UpdateSliderPositionHandler.php
@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Oksydan\IsImageslider\Handler\Slide;
+
+use Oksydan\IsImageslider\Cache\TemplateCache;
+use PrestaShop\PrestaShop\Core\Grid\Position\Exception\PositionDataException;
+use PrestaShop\PrestaShop\Core\Grid\Position\Exception\PositionUpdateException;
+use PrestaShop\PrestaShop\Core\Grid\Position\GridPositionUpdater;
+use PrestaShop\PrestaShop\Core\Grid\Position\PositionDefinition;
+use PrestaShop\PrestaShop\Core\Grid\Position\PositionUpdateFactory;
+
+class UpdateSliderPositionHandler
+{
+    protected TemplateCache $templateCache;
+
+    protected GridPositionUpdater $gridPositionUpdater;
+
+    public function __construct(
+        TemplateCache $templateCache,
+        GridPositionUpdater $gridPositionUpdater
+    ) {
+        $this->templateCache = $templateCache;
+        $this->gridPositionUpdater = $gridPositionUpdater;
+    }
+
+    /**
+     * @throws PositionUpdateException
+     * @throws PositionDataException
+     */
+    public function handle(array $positions): void
+    {
+        $positionDefinition = new PositionDefinition(
+            'image_slider',
+            'id_slide',
+            'position'
+        );
+
+        $positionUpdateFactory = new PositionUpdateFactory(
+            'positions',
+            'rowId',
+            'oldPosition',
+            'newPosition',
+            'idParent'
+        );
+
+        $positionsData = [
+            'positions' => $positions,
+        ];
+
+        $positionUpdate = $positionUpdateFactory->buildPositionUpdate($positionsData, $positionDefinition);
+
+        $this->gridPositionUpdater->update($positionUpdate);
+
+        $this->templateCache->clearTemplateCache();
+    }
+}