Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't save new Slide in chrome #45

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

Aerue
Copy link
Contributor

@Aerue Aerue commented Sep 30, 2023

Add param 'with_seconds' as stated in DateTimeType.

We need to force the browser to display the seconds by adding the HTML attribute step if not already defined. Otherwise the browser will not display and so not send the seconds therefore the value will always be considered as invalid.

Add param 'with_seconds' as stated in DateTimeType.

We need to force the browser to display the seconds by adding the HTML attribute step if not already defined.
Otherwise the browser will not display and so not send the seconds therefore the value will always be considered as invalid.
@Oksydan
Copy link
Owner

Oksydan commented Oct 10, 2023

Hi @Aerue,

Thank you for your contribution.
Can you create an issue before submitting an issue in Falcon theme repository?
Can you fix errors from cs fixer? Missing , at the end of last element in array.

@Oksydan
Copy link
Owner

Oksydan commented Oct 23, 2023

Hi @Aerue,

we had no news from you in 2 weeks.
I did it for you and I am merging it.
Thank you for your contribution.

@Oksydan Oksydan merged commit 3df3ad0 into Oksydan:develop Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants