-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow build bundle inside oba_app
#78
feat: allow build bundle inside oba_app
#78
Conversation
@@ -67,6 +67,8 @@ You can find the latest published Docker images on Docker Hub: | |||
* `JDBC_URL` - The JDBC connection URL for your MySQL database. | |||
* `JDBC_USER` - The username for your MySQL database. | |||
* `JDBC_PASSWORD` - The password for your MySQL database. | |||
* GTFS (Optional, required only when using `oba_app` independently) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -5,6 +5,21 @@ NAMESPACE_PREFIX="x" | |||
NAMESPACE_URI="http://www.springframework.org/schema/beans" | |||
BEAN_ID="testAPIKey" | |||
|
|||
# Build bundle inside the container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a priority right now, but I noticed that the oba_app docker container has perl 5 installed in it. How would you feel about rewriting the bash script in perl to make it more DRY, and easier to manage and extend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think would be a good idea to avoid overcomplicating our bootstrap.sh
script, while I haven't learned Perl, I am willing to learn and apply it to the processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great 👍
Allow to build bundle inside
oba_app
, you can try with:Result: