Leo Add ability to create a team from the Add Team option of User Management #453

Chuehleo · 2023-07-20T05:42:10Z

Description

Related PRS (if any):

To test this backend PR you need to checkout the #997 frontend PR.
…

Main changes explained:

Update the postTeam function in teamcontroller.js to avoid user creating duplicate teams.
…

How to test:

check into current branch in backend and frontend
do 'npm run build' and 'npm start' to run this PR locally
rest, follow frontend PR

Screenshots or videos of changes:

Note:

Include the information the reviewers need to know.

sxiong5

Tested with PR#997, and it worked as expected! Great job!

DavidC0126

Tested with frontend PR#997 and it worked as intended.

ramyaram2092

Hello @Chuehleo there is some issue with the branch name as it has special characters. How to switch to this branch Leo-Add-ability-to-create-a-team-from-the-“Add-Team”-option-of-User-Management?

mounica-dingari-by · 2023-07-21T04:12:15Z

Hi @Chuehleo , I've tested this feature along with PR#997 and it works perfectly, as intended. But, I'd like to suggest that, please close the modal window once the 'confirm' button is pressed.

ramyaram2092 · 2023-07-21T04:14:40Z

Hi @Chuehleo , I've tested this feature along with PR#997 and it works perfectly, as intended. But, I'd like to suggest that, please close the modal window once the 'confirm' button is pressed.

Hello @mounica-dingari-by could you mention the branch name you used to test this PR?

mounica-dingari-by · 2023-07-21T04:17:01Z

Hi @Chuehleo , I've tested this feature along with PR#997 and it works perfectly, as intended. But, I'd like to suggest that, please close the modal window once the 'confirm' button is pressed.

Hello @mounica-dingari-by could you mention the branch name you used to test this PR?

Hi @ramyaram2092 , for testing the backend, switch to this 'Leo-Add-ability-to-create-a-team-from-the-“Add-Team”-option-of-User-Management' branch and for frontend it's 'Leo_add_create_team_ability_to_add_team_popup'.

ramyaram2092 · 2023-07-21T04:26:13Z

Leo-Add-ability-to-create-a-team-from-the-“Add-Team”-option-of-User-Management

I couldnt find this branch name @mounica-dingari-by

mounica-dingari-by · 2023-07-21T04:30:31Z

Leo-Add-ability-to-create-a-team-from-the-“Add-Team”-option-of-User-Management

I couldnt find this branch name @mounica-dingari-by

@ramyaram2092 , please do git fetch first , so that you'll see all the latest branches and then you can switch to this "Leo-Add-ability-to-create-a-team-from-the-“Add-Team”-option-of-User-Management" branch

Shreyj14 · 2023-07-21T05:33:19Z

Hi @Chuehleo

I tested the PR with #997 as mentioned above and it works as intended, and I was able to create the team.

As mentioned earlier, it would be nice if you close the add team window once the team is assigned as it will be much clear for the user to know that the team was assigned.

new_recording_-_7_21_2023._1_24_08_am.Original.mp4

iTvX · 2023-07-21T17:49:47Z

Tested on the back end again, and everything is fine. As I mentioned early, an error message like "This team isn't found, you need to create a team first." may be better.

253168100-a68e6667-225c-4948-974d-97a3f6c9b7e0.-.01.mp4

ramyaram2092

It was an issue with vscode terminal. I was able to pull the branch successfully outside the ide
Thank you for your inputs @mounica-dingari-by
@Chuehleo the functionality works well. Uploaded the testing video in front end PR 997
Approving the PR on the same note

shiva2096

Hi @Chuehleo

Great work ! The functionality is working as expected.

Screen.Recording.2023-07-15.at.12.37.13.AM.mov

igorrochadasilva

Hi @Chuehleo !

I tested the PR with #997 and it works as intended, and I was able to create the team.

Great work! 😃
Obs: When I tried to create a already existing team, It didn't created, but I received the message: "Team added successfully", I don't know if it would be good receive a message: "The team is already created" ?

vemanamadhu

Good job. Left comments on #997

mahamakhan

Left comments on frontend. Works perfectly fine.

Indujaks

Tested Changes, works as expected!

yaow62023

I have tested your PR, all the comment at PR# 997. Great Work!

zuhang2000

Tested with PR 997. Left comment there. And it worked as expected! Great job!
My comment on 997: OneCommunityGlobal/HighestGoodNetworkApp#997 (review)

mahamakhan

Tested the functionality and was able to create a team and add it successfully.

ThapeloMasasa

The functionality works as intended both for the backend and the frontend. and the code is well written

winghojackyli

Hello @Chuehleo , this backend PR was tested along with the frontend #997 PR and they work great together. It has been approved and comment left here.

OneCommunityGlobal/HighestGoodNetworkApp#997 (review)

Abiddy

Works well

Screencast.from.08-12-2023.08.52.17.PM.webm

veronicacheng2

Hi @Chuehleo, I have tested the PR with the frontend. Everything works as intended. Comments left on #997.

winghojackyli

Hi @Chuehleo , I've tested this PR with the updated frontend PR and they work well together.
Approval with comments left here: OneCommunityGlobal/HighestGoodNetworkApp#997 (review)

Shubhu0 · 2023-09-09T16:19:07Z

PR working as intended. Good job!

Shiwani99 · 2023-09-15T22:05:54Z

Hi,
Great work. Added my comments to front end PR#453.

wantingxu7 · 2023-09-16T02:43:31Z

Good work! works as intended. Comment in FE #997

RheaWu1212 · 2023-10-01T00:21:58Z

Tested with FE #997, comments there.

JeffLi117

Review left on FE PR # 997.

yi-lin-1234

Hi, I tested this PR with #997, and it works as intended. Great work!

Screen.Recording.2023-10-09.at.5.17.47.PM.mov

StrawberryCalpico

Hi I tested this PR, details in #997

malikjahanzaib

Hi @Chuehleo, I tested this PR and it works as intended. Left detailed review on FE PR.

KavyaAlla · 2023-10-26T00:16:20Z

Hi @Chuehleo tested this with #997 and worked as intended. Details in #997

…-the-“Add-Team”-option-of-User-Management

navneeeth

Hello, @Chuehleo! I tested this functionality and have commented the full review on the FE PR while addressing an issue. Good implementation!

navneeeth

Approving after the recent fix on the FE. Great job!

Update teamController.js

8000203

Chuehleo changed the title ~~Update teamController.js~~ Leo Add ability to create a team from the “Add Team” option of User Management Jul 20, 2023

Chuehleo mentioned this pull request Jul 19, 2023

Leo Add ability to create a team from the “Add Team” option of User Management OneCommunityGlobal/HighestGoodNetworkApp#997

Merged

sxiong5 approved these changes Jul 20, 2023

View reviewed changes

DavidC0126 approved these changes Jul 20, 2023

View reviewed changes

ramyaram2092 reviewed Jul 21, 2023

View reviewed changes

Chuehleo changed the title ~~Leo Add ability to create a team from the “Add Team” option of User Management~~ Leo Add ability to create a team from the Add Team option of User Management Jul 21, 2023

Shreyj14 approved these changes Jul 21, 2023

View reviewed changes

ramyaram2092 approved these changes Jul 21, 2023

View reviewed changes

shiva2096 approved these changes Jul 22, 2023

View reviewed changes

igorrochadasilva reviewed Jul 22, 2023

View reviewed changes

vemanamadhu approved these changes Jul 22, 2023

View reviewed changes

mahamakhan approved these changes Jul 23, 2023

View reviewed changes

Indujaks approved these changes Jul 27, 2023

View reviewed changes

yaow62023 approved these changes Jul 28, 2023

View reviewed changes

zuhang2000 approved these changes Jul 29, 2023

View reviewed changes

mahamakhan approved these changes Jul 30, 2023

View reviewed changes

ThapeloMasasa approved these changes Aug 1, 2023

View reviewed changes

winghojackyli approved these changes Aug 4, 2023

View reviewed changes

Abiddy approved these changes Aug 13, 2023

View reviewed changes

veronicacheng2 approved these changes Aug 15, 2023

View reviewed changes

winghojackyli approved these changes Aug 19, 2023

View reviewed changes

JeffLi117 approved these changes Oct 7, 2023

View reviewed changes

yi-lin-1234 approved these changes Oct 9, 2023

View reviewed changes

StrawberryCalpico approved these changes Oct 11, 2023

View reviewed changes

malikjahanzaib approved these changes Oct 21, 2023

View reviewed changes

Merge branch 'development' into Leo-Add-ability-to-create-a-team-from…

f6d836e

…-the-“Add-Team”-option-of-User-Management

one-community added the Moved to Final Review label Nov 30, 2023

navneeeth suggested changes Nov 30, 2023

View reviewed changes

navneeeth approved these changes Dec 4, 2023

View reviewed changes

one-community merged commit 783c384 into development Dec 5, 2023
3 checks passed

one-community mentioned this pull request Dec 12, 2023

Backend Release to Main [1.25] #652

Merged

Leo Add ability to create a team from the Add Team option of User Management #453

Leo Add ability to create a team from the Add Team option of User Management #453

Conversation

Chuehleo commented Jul 20, 2023

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

Note:

sxiong5 left a comment • edited Loading

Choose a reason for hiding this comment

DavidC0126 left a comment • edited Loading

Choose a reason for hiding this comment

ramyaram2092 left a comment • edited Loading

Choose a reason for hiding this comment

mounica-dingari-by commented Jul 21, 2023

ramyaram2092 commented Jul 21, 2023

mounica-dingari-by commented Jul 21, 2023

ramyaram2092 commented Jul 21, 2023

mounica-dingari-by commented Jul 21, 2023

Shreyj14 commented Jul 21, 2023 • edited Loading

iTvX commented Jul 21, 2023

ramyaram2092 left a comment

Choose a reason for hiding this comment

shiva2096 left a comment

Choose a reason for hiding this comment

igorrochadasilva left a comment

Choose a reason for hiding this comment

vemanamadhu left a comment

Choose a reason for hiding this comment

mahamakhan left a comment

Choose a reason for hiding this comment

Indujaks left a comment

Choose a reason for hiding this comment

yaow62023 left a comment

Choose a reason for hiding this comment

zuhang2000 left a comment

Choose a reason for hiding this comment

mahamakhan left a comment

Choose a reason for hiding this comment

ThapeloMasasa left a comment

Choose a reason for hiding this comment

winghojackyli left a comment

Choose a reason for hiding this comment

Abiddy left a comment

Choose a reason for hiding this comment

veronicacheng2 left a comment

Choose a reason for hiding this comment

winghojackyli left a comment

Choose a reason for hiding this comment

Shubhu0 commented Sep 9, 2023

Shiwani99 commented Sep 15, 2023

wantingxu7 commented Sep 16, 2023

RheaWu1212 commented Oct 1, 2023

JeffLi117 left a comment

Choose a reason for hiding this comment

yi-lin-1234 left a comment

Choose a reason for hiding this comment

StrawberryCalpico left a comment

Choose a reason for hiding this comment

malikjahanzaib left a comment

Choose a reason for hiding this comment

KavyaAlla commented Oct 26, 2023

navneeeth left a comment

Choose a reason for hiding this comment

navneeeth left a comment

Choose a reason for hiding this comment

sxiong5 left a comment •

edited

Loading

DavidC0126 left a comment •

edited

Loading

ramyaram2092 left a comment •

edited

Loading

Shreyj14 commented Jul 21, 2023 •

edited

Loading