Navneeth create see teams management tab custom permission

[navneeeth]

Description

Related PRs:

This PR is linked to the FE PR #1359.

Main changes explained:

• Updated the permission checks for not allowing listing users (used while adding members) and adding new teams and adding new members if the user also does not have the seeTeamsManagementTab permissions.
• Added comments to define the permission checks.
• Fixed the regex check in src/models/team.js to allow team creation without a team code from the Teams page.
• Updated the hasPermission function call based on the latest update in its definition.

How to test:

1. check into current branch
2. do npm install and npm run build and npm run start successively to run this PR locally

[Shiwani99]

Hi,
Great Work. Left comments at frontend PR#1359.

[lacnoskillz]

Hi I'm trying to test your changes and having trouble creating an account with a Owner role.
Below I don't see the option to make a owner account to test. I'm currently logged in as the [email protected] when attempting to create

[malikjahanzaib]

Hi @navneeeth, I have tested the features implemented in this PR and everything seems to work fine. Detailed review in the FE PR #1359. Nice work!

[JYXiao-2021]

Hi, great job. I left my comment on FE.

[RheaWu1212]

Hi I'm trying to test your changes and having trouble creating an account with a Owner role. Below I don't see the option to make a owner account to test. I'm currently logged in as the [email protected] when attempting to create

Hi I have the same issue here:

[StrawberryCalpico]

Hi! I just reviewed the PR, it works as expected. Great job! I can assign the permission, create/edit team, and delete successfully. Details in #1359

[wantingxu7]

Hi, the PR LGTM, left detailed comment in FE 1359. Good job!

[RheaWu1212]

Hi I'm trying to test your changes and having trouble creating an account with a Owner role. Below I don't see the option to make a owner account to test. I'm currently logged in as the [email protected] when attempting to create

Hi I have the same issue here:

[navneeeth]

@lacnoskillz @RheaWu1212 Hi, you cannot create an Owner account. You need to contact Jae to upgrade one of your test accounts to an Owner account in order to test this PR. Thank you!

[palakgosalia]

Hi! I just reviewed the PR, it works as expected. I have left a comment in #1359

[RheaWu1212]

Hi! I reviewed the PR again after I had owner account and I have left a comment in FE.

[Lin1404]

Hi! I just reviewed the PR, it works as expected. I have left a comment in FE PR

[ChirayuRai]

Hey! I have left my comments on FE #1359

[shubhankarval]

Hey @navneeeth, I’m getting an error while trying to run this PR.

[navneeeth]

Hey @navneeeth, I’m getting an error while trying to run this PR.

Hello, @shubhankarval! Thanks for your review. Since the code has not changed since the last set of reviewers successfully tested it, I believe that this is a caching issue.

I just tried running the backend again with this PR and it works as expected:

For the FE:

Switch to the navneeth-create-see-teams-management-tab-custom-permission branch if on VS Code.
In the terminal:

git pull navneeth-create-see-teams-management-tab-custom-permission
npm install
npm run start:local

For the BE:

Switch to the navneeth-create-see-teams-management-tab-custom-permission branch if on VS Code.
In the terminal:

git pull navneeth-create-see-teams-management-tab-custom-permission
npm install
npm run build
npm run start

Please try again with the above steps and let me know. Thank you!

re-requested

will re-request since the changes are significant

[tsunami776]

Comment and test video left in FE PR. Great work!

[Shiwani99]

Hi,
Left my comments at frontend PR#1359. Great work.

[wantingxu7]

comment in FE, good work!

[shubhankarval]

Hey @navneeeth, great job! Left a comment on FE PR #1359

[Alforoan]

I left a comment on the fe pr.

[Pandani07]

Tested this PR and everything works as expected. Left a video of the testing on the frontend PR.

[XiaohanMeng]

Hi! I've completed my review of the PR and everything functions as anticipated. I've provided feedback directly on the FE.
OneCommunityGlobal/HighestGoodNetworkApp#1359 (review)