Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roberto-Fixes assign badge delay #562

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

robertoooc
Copy link
Contributor

@robertoooc robertoooc commented Oct 8, 2023

Description

When assigning badges to users specifically on the badgemagement, there was either a delayed response which would take minutes to update the user profile or it wouldn't update at all.

Screenshot 2023-09-30 at 8 55 35 PM

Related PRS (if any):

To test this backend PR you need to checkout the #1390 frontend PR.

Main changes explained:

  • Adds if statement to badgeController.js to check if cache has user's information, if it does then clear that cache so when you visit the user's profile the updates will show immediately.

How to test:

  1. check into current branch
  2. do npm install, npm run build, and npm start to run this PR locally
  3. Follow FE instructions

Note:

Please make sure to run npm run build, if not the code will not be compiled and changes will not be shown.

Copy link
Contributor

@StrawberryCalpico StrawberryCalpico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I test this pr and it works as intended. Great Work!

video2699265447.mp4

Copy link
Contributor

@navneeeth navneeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robertoooc! Tested your changes and they LGTM! Commented a full review on the frontend PR.

Copy link

@malikjahanzaib malikjahanzaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertoooc, I tested your changes, and all the fixes in this PR work as intended. Detailed review left on FE PR #1390. Great work!

Copy link
Contributor

@tsunami776 tsunami776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test video and comment left in FE PR. Nice work! I worked on a similar issue related to delay update and I also found it was related to cache.

Copy link

@JYXiao-2021 JYXiao-2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left my comment on FE.

Copy link

@Shubhu0 Shubhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robertoooc, I tested your changes, and all the fixes in this PR are working as intended. Detailed review on Frontend PR #1390.

Copy link

@JeffLi117 JeffLi117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review left on FE PR #1390.

@RheaWu1212
Copy link
Contributor

Hi, I left my comment on FE#1390.

Copy link

@Cloid Cloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, I ledge a comment on FE#1390

Copy link

@ChirayuRai ChirayuRai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I left my comment on FE#1390.

@Lin1404 Lin1404 self-requested a review October 20, 2023 11:50
Copy link

@shubhankarval shubhankarval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend looks good, left a change request on FE #1390.

@Lin1404
Copy link
Contributor

Lin1404 commented Oct 20, 2023

Hi, I test this pr and it works as intended. I left my comment on FE#1390.

@palakgosalia
Copy link

Hey, I have left a detailed review on PR 1390. Thank you

Copy link

@KurtisIvey KurtisIvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code once again. Cache is handled exactly as desired. No console errors detected during testing either.

Screenshot 2023-11-10 at 12 02 18 PM

Badges updated after 1 refresh as mentioned in the testing instructions. I refreshed from the user's profile page in order to see if the changes took place. Also logged out and under a different user with the new badge still persisting. Fantastic job!
Screenshot 2023-11-10 at 11 17 04 AM
Screenshot 2023-11-10 at 11 16 23 AM

@one-community one-community merged commit 8c9eaf0 into development Nov 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.