Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XiaoW_Add feature of auto restart server upon saving changes #565

Conversation

wang9hu
Copy link
Contributor

@wang9hu wang9hu commented Oct 10, 2023

Description

This PR adds a feature that auto restart the server upon any changes in the /src directory. By running npm run dev, developers do not need to rebuild and restart server, which improves development efficiency.

Main changes explained:

  • add nodemon package for auto restarting upon changes
  • add npm run dev command in package.json
  • modify readme command description
  • change parser from babel-eslint to @babel/eslint-parser in .eslintrc because babel-eslint is deprecated. For more info, check here
  • remove babel-eslint package

How to test:

  1. check into current branch
  2. do npm install to install
  3. do npm run dev to start the server
  4. make changes to files in /src and save files, use frontend or other methods to verify that those changes can be reflected

Note:

Include the information the reviewers need to know.

…ommand description, change parser from babel-eslint to @babel/eslint-parser in eslintrc
@wang9hu wang9hu marked this pull request as ready for review October 10, 2023 21:30
Copy link
Member

@one-community one-community left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xiao W: "yeah, I believe it is ok to merge, it should be just a QoL improvement"

@one-community one-community merged commit dc6c34e into development Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants