Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim add materials list routing #567

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

tdkent
Copy link
Contributor

@tdkent tdkent commented Oct 11, 2023

Description

Backend updates to support the BM Dashboard materials list page.

Related PRS

Main changes explained:

  • Add new database schema models/inventoryItemMaterial.js
  • Update existing schema models/inventoryItemType.js
  • Add new api route “/bmdashboard/materials”
  • Add new subdirectory routes/bmdashboard and file bmMaterialsRouter.js with GET request
  • Add new subdirectory controllers/bmdashboard and file bmMaterialsController.js
  • Controller fetches all data objects in new inventoryMaterial collection in MongoDB
  • Populates with data objects from inventoryItemType, userProfiles, and projects collections

How to test:

  1. git checkout Tim_add_materials_list_routing
  2. npm install
  3. npm run build
  4. npm start

Notes:

  • The edit icons in the table currently are not hooked up to anything and return null

Copy link

@ChirayuRai ChirayuRai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All functionality on frontend is working, and all information is showing up correctly on home page.

Only issues are editing seem to not be working, so I cannot test that functionality.

Screen.Recording.2023-10-11.at.2.49.16.PM.mov

@tdkent
Copy link
Contributor Author

tdkent commented Oct 11, 2023

Looks good! All functionality on frontend is working, and all information is showing up correctly on home page.

Only issues are editing seem to not be working, so I cannot test that functionality.

Screen.Recording.2023-10-11.at.2.49.16.PM.mov

Thanks for your review. As explained in the frontend PR description (which is where your change request should have been made since it is a frontend issue), the edit buttons currently return null by design.

@olenadanykh
Copy link

olenadanykh commented Oct 12, 2023

Looks good! All front-end functionality works as expected. Great job.

I've left a video recording in the corresponding front-end PR.

Copy link
Contributor

@tsunami776 tsunami776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment and test video left on FE PR. Great job!

Copy link
Contributor

@StrawberryCalpico StrawberryCalpico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I tested your PR, worked as expected, details in #1401

Copy link

@JeffLi117 JeffLi117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment left on FE PR #1401.

Copy link

@malikjahanzaib malikjahanzaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tdkent, I have tested your PR and everything seems to work perfectly. Left detailed review and test recordings on FE. Great job!!!

@RheaWu1212
Copy link
Contributor

Comment left on FE PR #1401.

@beblicarl beblicarl self-requested a review October 18, 2023 12:17
@beblicarl
Copy link
Contributor

Commented on the frontend PR

Copy link

@KurtisIvey KurtisIvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left main review on pr1401.

Would like to see chronological sort implemented in the mongodb query, so the results are return chronologically on the frontend.

pr1401 does this sort via the usage date
pr1401 need to confirm if purchases sorted via date
pr1401 does updates sort via date

@KurtisIvey Thanks for your review. I agree there should be sorting and additional filtering options. However, the PR was already so big I decided to stay focused on a MVP approach. I have already added this task to the Phase 2 WBS Sheet. For now I think its more important to get this branch merged since it adds many new file structure elements that are essential to other devs working on Phase 2.

Copy link

@KurtisIvey KurtisIvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification was given, so this things all good to go 👍🏻

@one-community one-community merged commit 95d787c into development Oct 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.