-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roberto - For Main Branch- sends email to Jae whenever Admin or Owner accounts are created or password reset #570
Roberto - For Main Branch- sends email to Jae whenever Admin or Owner accounts are created or password reset #570
Conversation
…r passwords reset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertoooc, I have already tested PR #569 and it is working fine about the owner account. I tested this PR and it works exactly like that one but this time for Admin and Owner accounts both. So when I created and reset password for Admin and Owner accounts, an email was sent out notifying about the respective change. Nice work!!!
Screenshots:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @robertoooc, I tested this PR and it works as intended, good job!
Creating new Admin account:
Resetting password for an Admin account:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertoooc, I've tested these actions:
- reset an Owner's password as Owner
- created an Admin account as Owner
- reset the new Admin's password as Owner
- created an Admin account as Admin
- reset the new Admin's password as Admin
All received corresponding email notifications. Well done!
PR570.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a more detailed comment on PR#569, but I'm having the same issue with this one. Can not create user with the backend in this branch because "location" is not being parsed correctly as a string. This is not due to the code changes in this PR but rather due to the changes to the "development" branch of the front end since this PR was submitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertoooc tested with admin accounts in continuation to PR#569 and it sends email for new admin account and password change for the same. Here's the screenshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @robertoooc, I have tested PR#569 and PR#570 works correctly as well. Please take the below screenshot as references:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I commented on PR 569
- signed in as owner
- created an admin account, received email verification
- reset admin account password, received email verification
This added feature works great!
Description
Like PR 569 this PR sends an email whenever an Owner account is created or their password is reset. However this PR is meant for the main branch so it also includes an email sent for the creation of Admin accounts and their passwords reset as well.Related PRS (if any):
This backed PR is a continuation of 569
Main changes explained:
How to test:
Screenshots or videos of changes:
Note:
PR 569 is a prerequisite to this PR so check it out first. This is a continuation of that PR.