-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leo_fix_issue_update_with_updating_existing_password #571
Leo_fix_issue_update_with_updating_existing_password #571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi I tested your PR, details on FE#1414
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments left on FE #1414.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested PR and left comments on FE#1414
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Chuehleo, I have tested this PR and left detailed review on FE #1414.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi I have read your code and tested your PR, details on FE#1414.
Hey, tested your PR and left a comment on FE#1414. |
Hi I tested your PR and left a comment on FE#1414. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I have test your PR, and everything works great! First, I have logged in to my owner account and changed my password. After change my password, I have logged in again with my new password and it work correctly. Next, I have reset the password of my volunteer account from the owner account and try to logged in with my volunteer account. The password works as expected. Finally, in the volunteer account, I have check the update password for different account and it is not appear as describe. Great work !
HGN.APP.-.Google.Chrome.2023-10-14.07-47-55.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I looked at your code and tested the changes as well. Those comments are on FE#1414.
I've tested this PR and left a comment with more details in #1414. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the frontend and the functionality works as intended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and left a comment on FE PR 1414.
Description
Related PRS (if any):
To test this backend PR you need to checkout the #1414 frontend PR.
…
Main changes explained:
…
How to test:
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.