Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leo_fix_issue_update_with_updating_existing_password #571

Conversation

Chuehleo
Copy link
Contributor

Description

Screenshot 2023-10-13 151833

Related PRS (if any):

To test this backend PR you need to checkout the #1414 frontend PR.

Main changes explained:

  • modify the logic in UpdatePassword and ValidatePassword function

How to test:

  1. check into current branch in backend and frontend
  2. do 'npm run build' and 'npm start' to run this PR locally
  3. rest, follow frontend PR

Screenshots or videos of changes:

Note:

Include the information the reviewers need to know.

Copy link
Contributor

@StrawberryCalpico StrawberryCalpico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I tested your PR, details on FE#1414

Copy link

@JeffLi117 JeffLi117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments left on FE #1414.

Copy link

@Cloid Cloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR and left comments on FE#1414

Copy link

@malikjahanzaib malikjahanzaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chuehleo, I have tested this PR and left detailed review on FE #1414.

Copy link

@yangfan2001 yangfan2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I have read your code and tested your PR, details on FE#1414.

@shubhankarval
Copy link

Hey, tested your PR and left a comment on FE#1414.

@RheaWu1212
Copy link
Contributor

Hi I tested your PR and left a comment on FE#1414.

Copy link

@TuanDinh140194 TuanDinh140194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I have test your PR, and everything works great! First, I have logged in to my owner account and changed my password. After change my password, I have logged in again with my new password and it work correctly. Next, I have reset the password of my volunteer account from the owner account and try to logged in with my volunteer account. The password works as expected. Finally, in the volunteer account, I have check the update password for different account and it is not appear as describe. Great work !

HGN.APP.-.Google.Chrome.2023-10-14.07-47-55.mp4

Copy link

@ChirayuRai ChirayuRai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I looked at your code and tested the changes as well. Those comments are on FE#1414.

@AriaYu927
Copy link
Contributor

I've tested this PR and left a comment with more details in #1414.

Copy link

@shubhankarval shubhankarval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Chuehleo , left a comment on FE PR #1414.

@beblicarl
Copy link
Contributor

I have reviewed the frontend and the functionality works as intended

Copy link

@Cloid Cloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and left a comment on FE PR 1414.

@one-community one-community merged commit 3753502 into development Dec 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.