Xiaow cleanup old timer and modify timer behavior for better UX #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang9hu
changed the title
|
Hey, I have left a detailed review on PR 1455. Great work. Thank you |
|
Hi @wang9hu I have tested the PR. Detailed review at #1455 |
navneeeth
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the old timer related code and files, and modify timer behavior. Now if users stop timer before it runs out and log the passed time, the remaining time will be come the goal for the next timer, and if timer run out by itself and user log the time, the goal for next timer will be set back to the initial goal.
Related PRS (if any):
This backend PR is related to the frontend PR#1455.
Main changes explained:
initialGoalin the timer model…
How to test:
npm installandnpm run devto run this PR locally5.1 when logging time before timer runs out, the next goal is what is remaining from last timer
5.2 when logging time after timer runs out, the next goal is what is set as the initial goal.
5.3 try to break it.
5.4 (new) now if there are multiple tabs (on the same browser or different browsers), once timer runs out, the ringing effect should be consistent if user add more or log time on any one tab.
Screenshots or videos of changes:
how to set the initial goal (used to be Goal for today):
Note:
The initial goal can only be set by editing and saving goal at the bottom of the timer modal.