Xiao F Give manager default permission to suggest instead of edit #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunami776
added
Do Not Review
|
Hey, I have left a detailed comment in PR 1458. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manager has both edit and suggest permissions in the database, but edit permission overrides suggest so that 'suggest' button won't appear for manager.
Related PRS (if any):
PR#1458
Main changes explained:
src/utilities/createInitialPermissions.jsto initialize manager permission with suggestHow to test:
npm install,npm run buildandnpm startto run this PR locallyDifficulties: Although I turned off edit permission for manager with owner account and ran the BE code in the PR, the edit permission on manager will be restored after some time. Any help will be appreciated.
Screenshots or videos of changes:
XiaoF.manager.permission.mp4
Note:
TypeError: Cannot read property 'permissions' of nullerror exists on dev branch: