-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wanting new make 5 letter codes editable only by admin&owner #594
Wanting new make 5 letter codes editable only by admin&owner #594
Conversation
Hi @wantingxu7 , I've tested this PR and left a comment under #1485 with more details. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wantingxu7, left detailed review on FE PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment on FE PR #1485. Everything works as intended, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR and provided a full review at #1485 Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wantingxu7 ,
I left a more detailed review for your frontend PR. Great job!
Hey, I have reviewed your PR and left a detailed comment in PR 1485. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve tested both of your PRs and they worked as expected. More details can be found in the FE PR. Nice work!
Hi @wantingxu7 Left detailed review at PR #1485 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments left in the FE, Thank you for the nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Comment Reference:
#594 (comment)
Hi @wantingxu7 , |
I tested this PR with the related front end PR please see the full review there #1485 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wantingxu7 , I left a detailed review on the Frontend PR1485
Description
Related PRS (if any):
FE #1485
Main changes explained:
update userProfileController.js
…
How to test:
npm run build
andnpm start
to run this PR locallyScreenshots or videos of changes:
see FE #1485
Note:
see FE #1485