Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wanting new make 5 letter codes editable only by admin&owner #594

Conversation

wantingxu7
Copy link
Contributor

Description

截屏2023-11-03 上午11 16 18

Related PRS (if any):

FE #1485

Main changes explained:

update userProfileController.js

How to test:

  1. check into current branch and FE #1485
  2. do npm run build and npm start to run this PR locally

Screenshots or videos of changes:

see FE #1485

Note:

see FE #1485

@AriaYu927
Copy link
Contributor

Hi @wantingxu7 , I've tested this PR and left a comment under #1485 with more details. Thank you!

Copy link

@malikjahanzaib malikjahanzaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wantingxu7, left detailed review on FE PR.

Copy link

@shubhankarval shubhankarval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on FE PR #1485. Everything works as intended, great job!

Copy link

@sahilpatel18 sahilpatel18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and provided a full review at #1485 Good work!

Copy link
Contributor

@jerryren527 jerryren527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wantingxu7 ,

I left a more detailed review for your frontend PR. Great job!

@palakgosalia
Copy link

Hey, I have reviewed your PR and left a detailed comment in PR 1485. Thank you

Copy link
Contributor

@Shuhua-L Shuhua-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve tested both of your PRs and they worked as expected. More details can be found in the FE PR. Nice work!

@KavyaAlla
Copy link

KavyaAlla commented Nov 12, 2023

Hi @wantingxu7 Left detailed review at PR #1485

Copy link

@Changhao3220K Changhao3220K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments left in the FE, Thank you for the nice work!

@ptrpengdev
Copy link
Contributor

ptrpengdev commented Nov 18, 2023

The code works as expected. Great work!

Tested both Admin and Owner role:

  1. Update team code in weekly summaries component (Success)
  2. Update team code in user profile component (Success)

Env Setup:
frontend commit 60815f3 and backend commit c819cc8.

@ptrpengdev ptrpengdev self-requested a review November 18, 2023 03:51
Copy link
Contributor

@ptrpengdev ptrpengdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Comment Reference:
#594 (comment)

@Bali2Mohit
Copy link

Hi @wantingxu7 ,
I have reviewed and added comment on the frontend PR

@DragonSlayer2401
Copy link
Contributor

DragonSlayer2401 commented Dec 2, 2023

I tested this PR with the related front end PR please see the full review there #1485

Copy link
Contributor

@sucheta90 sucheta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wantingxu7 , I left a detailed review on the Frontend PR1485

@wantingxu7 wantingxu7 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.