Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiwani add permission for edit project category or status #650

Merged

Conversation

Shiwani99
Copy link
Contributor

Description

Make permission management fix for edit project category or status.

Related PRS (if any):

To test this backend PR you need to checkout the #1606 frontend PR.

Main changes explained:

  • Added condition for editProject permission to edit and update category and status for that project. The first condition for editProject checks if that permission is not present in frontPermissions and if it present then the if condition will not execute, but if the permission does not exist, it checks if the user has putProject permissions and if both of these permissions are not present then 403 error will be raised when trying to edit category and status.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Follow steps in frontend PR

Screenshots or videos of changes:

Before:

before.mov

After:

after.mov

Copy link
Contributor

@Shuhua-L Shuhua-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment left in the FE PR 1606

Copy link
Contributor

@ilyaflaks ilyaflaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR and everything works perfectly.
Detailed comment on the front end PR1606.

Copy link

@Alforoan Alforoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment on #1606

@chappdev2019
Copy link
Member

I left my comment on #1606

Copy link
Contributor

@Pandani07 Pandani07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as intended! Left a review on the frontend PR

@XiaohanMeng XiaohanMeng self-requested a review February 29, 2024 22:34
Copy link
Contributor

@XiaohanMeng XiaohanMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaushikMreddy
Copy link

I've left a review in the Frontend PR linked to this: OneCommunityGlobal/HighestGoodNetworkApp#1606 (comment)

Copy link
Contributor

@peter6866 peter6866 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as expected. I also left a comment in the frontend PR.

@akshit0211
Copy link

I left a review on the front-end PR. Review

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 23112ce into development Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.