Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yihan fix the issue that logged time missing on leaderboard #664

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

AriaYu927
Copy link
Contributor

Description

image

Main changes explained:

  • Update file timeEntryController.js for improving code logic.
  • Update file dashboardhelper.js for correcting the syntax of mongodb query (root cause of the problem).

How to test:

  1. check into current branch
  2. do npm run build and npm start to run this PR locally
  3. Clear site data/cache
  4. log as any user
  5. go to dashboard→ leaderboard
  6. verify if the Tangible Time and Total Time of each user is correct, which should match the sum of logged time in dashboard -> Tasks and Timelogs -> Current Week Timelog.

Screenshots or videos of changes:

Before:

Screen.Recording.2023-12-20.at.20.54.12.mov

After:

Screen.Recording.2023-12-20.at.20.54.58.mov

@one-community one-community merged commit 485f3ce into development Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants