Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shengwei (hotfix) fix the task scheduler to run weekly #675

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

ptrpengdev
Copy link
Contributor

@ptrpengdev ptrpengdev commented Jan 2, 2024

Description

image

Related PRS (if any):

Main changes explained:

  • Update file userProfileJobs.js to include new cron configuration

How to test:

  1. check into the current branch
  2. do npm install and ... to run this PR locally
  3. verify the cron expression specifies that the job should run at 1 minute past midnight every Sunday in PST in file userProfileJobs.js

Screenshots or videos of changes:

Note:

Include the information the reviewers need to know.

@ChengyanOo
Copy link
Member

Hi @ptrpengdev,

Can you please give a more detailed walk through about how to test if your change works?

Thank you!

@ptrpengdev
Copy link
Contributor Author

ptrpengdev commented Jan 3, 2024

Hi @ptrpengdev,

Can you please give a more detailed walk through about how to test if your change works?

Thank you!

Hi @ChengyanOo ,

This is a one-liner hotfix. All you have to do is verify that the cron expression is defined correctly in the userProfileJobs.js. This is expected to run every Sunday, 1 minute past midnight. Otherwise, you will have to wait until Sunday for manual testing. Thanks.

Copy link
Member

@ChengyanOo ChengyanOo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified cron expression in the userProfileJobs.js, logically correct.

@one-community one-community merged commit b84184f into development Jan 3, 2024
3 checks passed
@ptrpengdev ptrpengdev deleted the shengwei_fix_task_scheduler branch April 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants