Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shiwani Make permission for "Total Valid Weekly Summaries" number editable #747

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Shiwani Make permission for "Total Valid Weekly Summaries" number editable #747

merged 2 commits into from
Feb 27, 2024

Conversation

Shiwani99
Copy link
Contributor

@Shiwani99 Shiwani99 commented Feb 13, 2024 •
edited
Loading

Description

This is a new PR for #588

Related PRS (if any):

This frontend PR is related to the #1459 backend PR.

Main changes explained:

  • Added 'totalValidWeeklySummaries' to Owner and Administrator in createInitialPermissions.js

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Follow instructions in frontend PR

@Shiwani99 Shiwani99 mentioned this pull request Feb 13, 2024
Merged
cvtqx
cvtqx reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@cvtqx cvtqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works when testing from owner account but not from admin account. Left comment in FE PR.

@Shiwani99 Shiwani99 requested a review from cvtqx February 23, 2024 21:02
cvtqx
cvtqx approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@cvtqx cvtqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for owner, thanks for the clarification on the front end PR and updating the instructions. Approved.

@one-community one-community merged commit f026c65 into development Feb 27, 2024
3 checks passed
@one-community one-community mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvtqx cvtqx cvtqx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shiwani99 @cvtqx @one-community